[Signin] Remove a reference to an obsolete bug.

chrome/browser/services/gcm/gcm_service.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/services/gcm/gcm_service.h"
 
 #include <algorithm>
 #include <utility>
 
 #include "base/bind.h"
@@ skipping 454 matching lines @@
 
 void GCMService::RemoveAppHandler(const std::string& app_id) {
   DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));
   DCHECK(!app_id.empty());
 
   app_handlers_.erase(app_id);
 }
 
 void GCMService::Register(const std::string& app_id,
                           const std::vector<std::string>& sender_ids,
-                          RegisterCallback callback) {
+                          const RegisterCallback& callback) {
   DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));
   DCHECK(!app_id.empty());
   DCHECK(!sender_ids.empty());
   DCHECK(!callback.is_null());
 
   GCMClient::Result result = EnsureAppReady(app_id);
   if (result != GCMClient::SUCCESS) {
     callback.Run(std::string(), result);
     return;
   }
@@ skipping 35 matching lines @@
   content::BrowserThread::PostTask(
       content::BrowserThread::IO,
       FROM_HERE,
       base::Bind(&GCMService::IOWorker::Register,
                  base::Unretained(io_worker_.get()),
                  app_id,
                  normalized_sender_ids));
 }
 
 void GCMService::Unregister(const std::string& app_id,
-                            UnregisterCallback callback) {
+                            const UnregisterCallback& callback) {
   DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));
   DCHECK(!app_id.empty());
   DCHECK(!callback.is_null());
 
   GCMClient::Result result = EnsureAppReady(app_id);
   if (result != GCMClient::SUCCESS) {
     callback.Run(result);
     return;
   }
 
@@ skipping 26 matching lines @@
       content::BrowserThread::IO,
       FROM_HERE,
       base::Bind(&GCMService::IOWorker::Unregister,
                  base::Unretained(io_worker_.get()),
                  app_id));
 }
 
 void GCMService::Send(const std::string& app_id,
                       const std::string& receiver_id,
                       const GCMClient::OutgoingMessage& message,
-                      SendCallback callback) {
+                      const SendCallback& callback) {
   DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));
   DCHECK(!app_id.empty());
   DCHECK(!receiver_id.empty());
   DCHECK(!callback.is_null());
 
   GCMClient::Result result = EnsureAppReady(app_id);
   if (result != GCMClient::SUCCESS) {
     callback.Run(std::string(), result);
     return;
   }
@@ skipping 42 matching lines @@
 bool GCMService::IsStarted() const {
   DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));
   return !account_id_.empty();
 }
 
 bool GCMService::IsGCMClientReady() const {
   DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));
   return gcm_client_ready_;
 }
 
-void GCMService::GetGCMStatistics(GetGCMStatisticsCallback callback,
+void GCMService::GetGCMStatistics(const GetGCMStatisticsCallback& callback,
                                   bool clear_logs) {
   DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));
   DCHECK(!callback.is_null());
 
   request_gcm_statistics_callback_ = callback;
   content::BrowserThread::PostTask(
       content::BrowserThread::IO,
       FROM_HERE,
       base::Bind(&GCMService::IOWorker::GetGCMStatistics,
                  base::Unretained(io_worker_.get()),
                  clear_logs));
 }
 
-void GCMService::SetGCMRecording(GetGCMStatisticsCallback callback,
+void GCMService::SetGCMRecording(const GetGCMStatisticsCallback& callback,
                                  bool recording) {
   DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));
 
   request_gcm_statistics_callback_ = callback;
   content::BrowserThread::PostTask(
       content::BrowserThread::IO,
       FROM_HERE,
       base::Bind(&GCMService::IOWorker::SetGCMRecording,
                  base::Unretained(io_worker_.get()),
                  recording));
@@ skipping 176 matching lines @@
 }
 
 GCMAppHandler* GCMService::GetAppHandler(const std::string& app_id) {
   DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));
 
   std::map<std::string, GCMAppHandler*>::const_iterator iter =
       app_handlers_.find(app_id);
   return iter == app_handlers_.end() ? &default_app_handler_ : iter->second;
 }
 
-void GCMService::GetGCMStatisticsFinished(
-    GCMClient::GCMStatistics stats) {
+void GCMService::GetGCMStatisticsFinished(GCMClient::GCMStatistics stats) {
   DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));
-  request_gcm_statistics_callback_.Run(stats);
+  if (!request_gcm_statistics_callback_.is_null())
+    request_gcm_statistics_callback_.Run(stats);
 }

[Roger Tawa OOO till Jul 10th, 2014/05/09 11:51:00]

A lot of crashes were reported yesterday about this line. Why did you need to
add the if?

[Ilya Sherman, 2014/05/09 20:16:56]

Sorry, this was an unrelated change that I accidentally included in Patch Set 1,
and then quickly removed in Patch Set 2.  I added the if because this line was
crashing for me as well.  I split off that change to [
https://codereview.chromium.org/276833003/ ], from where jianli pointed me to a
more correct fix at [ https://codereview.chromium.org/277743002/ ].

 
 }  // namespace gcm