ios/chrome/browser/ui/overscroll_actions/overscroll_actions_controller.mm - Issue 2775623002: [ios] WebStateList owns all WebState it manages.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/ui/overscroll_actions/overscroll_actions_controller.mm

Issue 2775623002: [ios] WebStateList owns all WebState it manages. (Closed)

Patch Set: Fix ios_chrome_unittests. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« ios/chrome/browser/ui/fullscreen_controller.mm ('K') | « ios/chrome/browser/ui/fullscreen_controller.mm ('k') | ios/chrome/browser/ui/preload_controller.h » ('j') | ios/chrome/browser/ui/tab_switcher/tab_switcher_controller.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ios/chrome/browser/ui/overscroll_actions/overscroll_actions_controller.mm

diff --git a/ios/chrome/browser/ui/overscroll_actions/overscroll_actions_controller.mm b/ios/chrome/browser/ui/overscroll_actions/overscroll_actions_controller.mm

index fbec30aa4dbf90b7a15bcd6dae26103d7f8350f4..7a58ef157bff2484b87c895961b8c20b4196b8d5 100644

--- a/ios/chrome/browser/ui/overscroll_actions/overscroll_actions_controller.mm

+++ b/ios/chrome/browser/ui/overscroll_actions/overscroll_actions_controller.mm

@@ -519,7 +519,6 @@ NSString* const kOverscrollActionsDidEnd = @"OverscrollActionsDidStop";

[self disableOverscrollActions];

[_webViewScrollViewProxy removeObserver:self];

_webViewScrollViewProxy.reset();

- [webController removeObserver:self];

rohitrao (ping after 24h) 2017/03/26 23:21:22 Do we not need to remove webcontroller observers a

sdefresne 2017/03/28 15:15:05 This is done in Tab -onWebStateDestroyed:.

}

#pragma mark - Private