ios/chrome/browser/ui/fullscreen_controller.mm - Issue 2775623002: [ios] WebStateList owns all WebState it manages.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/ui/fullscreen_controller.mm

Issue 2775623002: [ios] WebStateList owns all WebState it manages. (Closed)

Patch Set: Fix ios_chrome_unittests. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/chrome/browser/ui/fullscreen_controller.mm

diff --git a/ios/chrome/browser/ui/fullscreen_controller.mm b/ios/chrome/browser/ui/fullscreen_controller.mm

index 2d37826f539b664ab1dde19a57616223b68c3f2f..6a1eeb96fb46f4943cf548fc458cb4f1645b01c9 100644

--- a/ios/chrome/browser/ui/fullscreen_controller.mm

+++ b/ios/chrome/browser/ui/fullscreen_controller.mm

@@ -713,10 +713,6 @@ BOOL CGFloatEquals(CGFloat a, CGFloat b) {

}

-- (void)webControllerWillClose:(CRWWebController*)webController {

- [webController removeObserver:self];

rohitrao (ping after 24h) 2017/03/26 23:21:22 When is this observer removed instead?

sdefresne 2017/03/28 15:15:05 In Tab -onWebStateDestroyed:.

#pragma mark -

#pragma mark CRWWebViewScrollViewObserver