Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Issue 2775553002: Adds the ability for WebContentsDelegate to decide if event should be updated (Closed)

Created:
3 years, 9 months ago by sky
Modified:
3 years, 9 months ago
Reviewers:
jam, sadrul
CC:
chromium-reviews, extensions-reviews_chromium.org, nasko+codewatch_chromium.org, creis+watch_chromium.org, kalyank, yusukes+watch_chromium.org, tfarina, mac-reviews_chromium.org, jam, piman+watch_chromium.org, jbauman+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, shuchen+watch_chromium.org, devtools-reviews_chromium.org, chromium-apps-reviews_chromium.org, xjz+watch_chromium.org, James Su, danakj+watch_chromium.org, pfeldman, miu+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Adds the ability for WebContentsDelegate to decide if event should be updated Currently the keyboard processing code for aura always marks the event as handled. This means no other EventHandlers see the event if a page has focus. For mus+ash we need to be able to control whether the event should be marked handled or not. This patch changes PreHandleKeyboardEvent() to return an enum indicating whether the event should be marked handled or not. BUG=701815 TEST=covered by tests R=jam@chromium.org, sadrul@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2775553002 Cr-Commit-Position: refs/heads/master@{#459341} Committed: https://chromium.googlesource.com/chromium/src/+/f65d9bb4555976b047385b392d40fc62e4df9f27

Patch Set 1 #

Patch Set 2 : update #

Patch Set 3 : Fix compile #

Unified diffs Side-by-side diffs Delta from patch set Stats (+248 lines, -167 lines) Patch
M chrome/browser/devtools/devtools_window.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/devtools/devtools_window.cc View 4 chunks +13 lines, -14 lines 0 comments Download
M chrome/browser/extensions/api/tab_capture/offscreen_tab.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/tab_capture/offscreen_tab.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/extensions/extension_view_host.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_view_host.cc View 2 chunks +7 lines, -10 lines 0 comments Download
M chrome/browser/extensions/global_shortcut_listener_chromeos.h View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/browser.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/browser.cc View 2 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/ui/browser_window.h View 1 2 chunks +3 lines, -6 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_cocoa.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_cocoa.mm View 1 2 2 chunks +12 lines, -10 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view.cc View 4 chunks +22 lines, -18 lines 0 comments Download
M chrome/test/base/test_browser_window.h View 1 2 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/test/base/test_browser_window.cc View 1 2 2 chunks +5 lines, -5 lines 0 comments Download
M content/browser/frame_host/interstitial_page_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/frame_host/interstitial_page_impl.cc View 2 chunks +5 lines, -6 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_delegate.h View 2 chunks +5 lines, -6 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_delegate.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.h View 1 chunk +5 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.cc View 4 chunks +20 lines, -5 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_unittest.cc View 3 chunks +9 lines, -5 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.h View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 3 chunks +7 lines, -4 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura_unittest.cc View 4 chunks +32 lines, -9 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_event_handler.h View 1 chunk +5 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_event_handler.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M content/public/browser/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A content/public/browser/keyboard_event_processing_result.h View 1 chunk +30 lines, -0 lines 0 comments Download
M content/public/browser/web_contents_delegate.h View 2 chunks +6 lines, -6 lines 0 comments Download
M content/public/browser/web_contents_delegate.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M extensions/browser/app_window/app_window.h View 1 chunk +3 lines, -3 lines 0 comments Download
M extensions/browser/app_window/app_window.cc View 3 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 26 (20 generated)
sky
3 years, 9 months ago (2017-03-23 05:10:53 UTC) #2
sky
sadrul: content-aura parts and chrome jam: content non-aura parts
3 years, 9 months ago (2017-03-23 05:11:47 UTC) #3
jam
lgtm
3 years, 9 months ago (2017-03-23 23:01:47 UTC) #20
sadrul
lgtm
3 years, 9 months ago (2017-03-24 00:17:02 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2775553002/40001
3 years, 9 months ago (2017-03-24 02:21:32 UTC) #23
commit-bot: I haz the power
3 years, 9 months ago (2017-03-24 02:27:36 UTC) #26
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/f65d9bb4555976b047385b392d40...

Powered by Google App Engine
This is Rietveld 408576698