chromeos:: Remove pointless ProxyResolverInterface.

chromeos:: Remove pointless ProxyResolverInterface.

Remove an interface that has a single implementation. Maybe
someone planned to use it to stub out ProxyResolverImpl at
some point in the distant past but got distracted. The class
that owns it is tested now, in any case.

Also hoist ProxyResolverImpl's implementation into
ProxyResolutionServiceProvider and rename
ProxyResolverDelegate to
ProxyResolutionServiceProvider::Delegate.

BUG=446115, 703217
Review-Url: https://codereview.chromium.org/2775503002
Cr-Commit-Position: refs/heads/master@{#458998}
Committed: https://chromium.googlesource.com/chromium/src/+/e1a7452ea991283a3b83942348e0d2c35a34fea9

[Daniel Erat, 2017-03-23 00:48:29]

derat@chromium.org changed reviewers:
+ jamescook@chromium.org, satorux@chromium.org

[Daniel Erat, 2017-03-23 00:48:30]

i think that this is the last one before i start making the changes that i
actually want to make!

https://codereview.chromium.org/2775503002/diff/20001/chrome/browser/chromeos...
File
chrome/browser/chromeos/dbus/chrome_proxy_resolution_service_provider_delegate.h
(right):

https://codereview.chromium.org/2775503002/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/dbus/chrome_proxy_resolution_service_provider_delegate.h:5:
#ifndef
CHROME_BROWSER_CHROMEOS_DBUS_CHROME_PROXY_RESOLUTION_SERVICE_PROVIDER_DELEGATE_H_
blegh

[Daniel Erat, 2017-03-23 00:48:36]

The CQ bit was checked by derat@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-23 00:49:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-23 02:01:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-23 02:02:00]

Dry run: This issue passed the CQ dry run.

[satorux1, 2017-03-23 02:18:54]

LGTM

I guess I was the "someone" but I don't remember what I was planning to do back
then. Thank you for removing an unnecessary layer.

[Daniel Erat, 2017-03-23 03:49:25]

The CQ bit was checked by derat@chromium.org

[commit-bot: I haz the power, 2017-03-23 03:49:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-23 03:53:32]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490240965377340,
"parent_rev": "31843a5be08800e6bdf2a1f7c07eef342ad1abc6", "commit_rev":
"e1a7452ea991283a3b83942348e0d2c35a34fea9"}

[commit-bot: I haz the power, 2017-03-23 03:54:50]

Description was changed from

==========
chromeos:: Remove pointless ProxyResolverInterface.

Remove an interface that has a single implementation. Maybe
someone planned to use it to stub out ProxyResolverImpl at
some point in the distant past but got distracted. The class
that owns it is tested now, in any case.

Also hoist ProxyResolverImpl's implementation into
ProxyResolutionServiceProvider and rename
ProxyResolverDelegate to
ProxyResolutionServiceProvider::Delegate.

BUG=446115,703217
==========

to

==========
chromeos:: Remove pointless ProxyResolverInterface.

Remove an interface that has a single implementation. Maybe
someone planned to use it to stub out ProxyResolverImpl at
some point in the distant past but got distracted. The class
that owns it is tested now, in any case.

Also hoist ProxyResolverImpl's implementation into
ProxyResolutionServiceProvider and rename
ProxyResolverDelegate to
ProxyResolutionServiceProvider::Delegate.

BUG=446115,703217

Review-Url: https://codereview.chromium.org/2775503002
Cr-Commit-Position: refs/heads/master@{#458998}
Committed:
https://chromium.googlesource.com/chromium/src/+/e1a7452ea991283a3b83942348e0...
==========

[commit-bot: I haz the power, 2017-03-23 03:54:51]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/e1a7452ea991283a3b83942348e0...