Use public Service Manager Connector API in Blink

Use public Service Manager Connector API in Blink

This takes advantage of the fact that the Connector API's usage in Blink
does not in practice expose any interesting or undesirable dependencies,
allowing us to use the API directly instead of wrapping it in a special
layered Blink/content implementation.

BUG=704501
Review-Url: https://codereview.chromium.org/2775483003
Cr-Commit-Position: refs/heads/master@{#460074}
Committed: https://chromium.googlesource.com/chromium/src/+/493602dbef2f87945e98f9765345d8d7bd908de9

[Ken Rockot(use gerrit already), 2017-03-23 16:20:22]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-23 16:20:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-23 16:24:04]

The CQ bit was unchecked by commit-bot@chromium.org

[Ken Rockot(use gerrit already), 2017-03-23 16:24:04]

rockot@chromium.org changed reviewers:
+ blundell@chromium.org, jam@chromium.org

[commit-bot: I haz the power, 2017-03-23 16:24:05]

Dry run: Try jobs failed on following builders:
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[commit-bot: I haz the power, 2017-03-23 16:24:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-23 16:24:57]

Dry run: Try jobs failed on following builders:
  android_cronet on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[Ken Rockot(use gerrit already), 2017-03-23 16:26:57]

NOTE: the CQ redness is the bot_update bug discussed here
https://groups.google.com/a/chromium.org/forum/?utm_medium=email&utm_source=f...

The patch works just fine :)

[Ken Rockot(use gerrit already), 2017-03-23 19:34:48]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-23 19:35:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-23 19:40:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-23 19:40:59]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Ken Rockot(use gerrit already), 2017-03-23 19:46:03]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-23 19:46:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-23 19:51:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-23 19:51:39]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[blundell, 2017-03-24 10:59:28]

This looks fantastic from a code simplification POV of course :D. I think the
key will be figuring out answers to the questions that I posed on the other CL.

[jam, 2017-03-24 14:38:13]

Thanks! This looks great to me; perhaps get Kentaro to take a look?

[Ken Rockot(use gerrit already), 2017-03-27 20:36:15]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-27 20:36:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ken Rockot(use gerrit already), 2017-03-27 20:37:00]

Description was changed from

==========
Use public Service Manager Connector API in Blink

This takes advantage of the Connector API's new reduced set of public
dependencies by using it directly from Blink and eliminating the
now redundant Blink-only Connector client library.

BUG=7004501
==========

to

==========
Use public Service Manager Connector API in Blink

This takes advantage of the fact that the Connector API's usage in Blink
does not in practice expose any interesting or undesirable dependencies,
allowing us to use the API directly instead of wrapping it in a special
layered Blink/content implementation.

BUG=7004501
==========

[Ken Rockot(use gerrit already), 2017-03-27 20:40:24]

Per offline discussion, I've rebased this CL so that it doesn't depend on any
kind of special or "invariant" client library, instead opting to expose
connector.h directly, as-is.

Because in practice BindInterface, Clone, and BindConnectorRequest are the
methods we anticipate using in Blink, and because none of these methods really
benefit from constrained type exposure, this should be fine.

[dglazkov, 2017-03-27 20:45:01]

dglazkov@chromium.org changed reviewers:
+ dglazkov@chromium.org

[dglazkov, 2017-03-27 20:45:02]

lgtm

[jam, 2017-03-27 20:50:09]

lgtm

[commit-bot: I haz the power, 2017-03-27 21:09:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-27 21:09:38]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[haraken, 2017-03-28 02:47:07]

LGTM

[blundell, 2017-03-28 07:21:34]

LGTM

[Ken Rockot(use gerrit already), 2017-03-28 07:22:07]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-28 07:22:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-28 09:03:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-28 09:03:09]

Dry run: This issue passed the CQ dry run.

[Ken Rockot(use gerrit already), 2017-03-28 12:04:21]

Description was changed from

==========
Use public Service Manager Connector API in Blink

This takes advantage of the fact that the Connector API's usage in Blink
does not in practice expose any interesting or undesirable dependencies,
allowing us to use the API directly instead of wrapping it in a special
layered Blink/content implementation.

BUG=7004501
==========

to

==========
Use public Service Manager Connector API in Blink

This takes advantage of the fact that the Connector API's usage in Blink
does not in practice expose any interesting or undesirable dependencies,
allowing us to use the API directly instead of wrapping it in a special
layered Blink/content implementation.

BUG=704501
==========

[Ken Rockot(use gerrit already), 2017-03-28 12:04:21]

rockot@chromium.org changed reviewers:
+ haraken@chromium.org

[Ken Rockot(use gerrit already), 2017-03-28 12:45:51]

The CQ bit was checked by rockot@chromium.org

[Ken Rockot(use gerrit already), 2017-03-28 12:45:51]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, jam@chromium.org, dglazkov@chromium.org,
blundell@chromium.org
Link to the patchset: https://codereview.chromium.org/2775483003/#ps80001
(title: ".")

[commit-bot: I haz the power, 2017-03-28 12:46:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-28 12:51:08]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1490705151406580,
"parent_rev": "03b5ef86dce1b086e2fb8b5434e523e0d9b473e3", "commit_rev":
"493602dbef2f87945e98f9765345d8d7bd908de9"}

[commit-bot: I haz the power, 2017-03-28 12:51:57]

Description was changed from

==========
Use public Service Manager Connector API in Blink

This takes advantage of the fact that the Connector API's usage in Blink
does not in practice expose any interesting or undesirable dependencies,
allowing us to use the API directly instead of wrapping it in a special
layered Blink/content implementation.

BUG=704501
==========

to

==========
Use public Service Manager Connector API in Blink

This takes advantage of the fact that the Connector API's usage in Blink
does not in practice expose any interesting or undesirable dependencies,
allowing us to use the API directly instead of wrapping it in a special
layered Blink/content implementation.

BUG=704501

Review-Url: https://codereview.chromium.org/2775483003
Cr-Commit-Position: refs/heads/master@{#460074}
Committed:
https://chromium.googlesource.com/chromium/src/+/493602dbef2f87945e98f9765345...
==========

[commit-bot: I haz the power, 2017-03-28 12:51:59]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/493602dbef2f87945e98f9765345...