Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 2775423005: [turbofan] Remove the --print-turbo-replay flag. (Closed)

Created:
3 years, 8 months ago by Jarin
Modified:
3 years, 8 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Remove the --print-turbo-replay flag. Review-Url: https://codereview.chromium.org/2775423005 Cr-Commit-Position: refs/heads/master@{#44224} Committed: https://chromium.googlesource.com/v8/v8/+/51ef3212bf57898f58ef3b433f5dc2692ee2bb50

Patch Set 1 #

Patch Set 2 : Actually remove the flag #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -144 lines) Patch
M BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
D src/compiler/graph-replay.h View 1 chunk +0 lines, -40 lines 0 comments Download
D src/compiler/graph-replay.cc View 1 chunk +0 lines, -92 lines 0 comments Download
M src/compiler/pipeline.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M src/flag-definitions.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M src/v8.gyp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Jarin
Could you take a look, please? (Red only.)
3 years, 8 months ago (2017-03-29 09:18:17 UTC) #4
Benedikt Meurer
LGTM!!1one
3 years, 8 months ago (2017-03-29 09:23:07 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2775423005/20001
3 years, 8 months ago (2017-03-29 10:49:29 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-03-29 10:51:28 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/51ef3212bf57898f58ef3b433f5dc2692ee...

Powered by Google App Engine
This is Rietveld 408576698