content/test/data/allowed_frames.html - Issue 2775393003: Fix crash in frame owner property replication.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/test/data/allowed_frames.html

Issue 2775393003: Fix crash in frame owner property replication. (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/test/data/allowed_frames.html

diff --git a/content/test/data/allowed_frames.html b/content/test/data/allowed_frames.html

index a9ccb90703134808d61f1ba6f89862d56d8047af..6ffcc05c064d0456b4a5c8ff670a1ff8896fa103 100644

--- a/content/test/data/allowed_frames.html

+++ b/content/test/data/allowed_frames.html

@@ -2,10 +2,10 @@

<head>

</head>

<body>

- <iframe name="frame0" id="child-0"></iframe>

- <iframe name="frame1" id="child-1" allow></iframe>

- <iframe name="frame2" id="child-2" allow="fullscreen vibrate" src="/cross-site/bar.com/title1.html"></iframe>

- <iframe name="frame3" id="child-3" allow="fullscreen vibrate" src="title1.html"></iframe>

nasko 2017/03/27 21:23:22 Why are the names removed?

alexmos 2017/03/28 00:50:18 I'm guessing this is because in InitRenderFramePro

+ <iframe id="child-0"></iframe>

+ <iframe id="child-1" allow></iframe>

+ <iframe id="child-2" allow="fullscreen vibrate" src="/cross-site/bar.com/title1.html"></iframe>

+ <iframe id="child-3" allow="fullscreen vibrate" src="title1.html"></iframe>

</body>

</html>

« no previous file with comments | « content/common/frame_owner_properties.cc ('k') | no next file » | no next file with comments »