content/test/data/allowed_frames.html - Issue 2775393003: Fix crash in frame owner property replication.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/test/data/allowed_frames.html

Issue 2775393003: Fix crash in frame owner property replication. (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <head>	2 <head>

3 </head>	3 </head>

4 <body>	4 <body>

5 <iframe name="frame0" id="child-0"></iframe>	5 <iframe id="child-0"></iframe>

6 <iframe name="frame1" id="child-1" allow></iframe>	6 <iframe id="child-1" allow></iframe>

7 <iframe name="frame2" id="child-2" allow="fullscreen vibrate" src="/cross-site /bar.com/title1.html"></iframe>	7 <iframe id="child-2" allow="fullscreen vibrate" src="/cross-site/bar.com/title 1.html"></iframe>

8 <iframe name="frame3" id="child-3" allow="fullscreen vibrate" src="title1.html "></iframe>	8 <iframe id="child-3" allow="fullscreen vibrate" src="title1.html"></iframe>
nasko 2017/03/27 21:23:22 Why are the names removed? Why are the names removed? alexmos 2017/03/28 00:50:18 I'm guessing this is because in InitRenderFramePro Show quoted text On 2017/03/27 21:23:22, nasko wrote: > Why are the names removed? I'm guessing this is because in InitRenderFrameProxy, we compare the FrameOwnerProperties to the set of default values, to decide whether or not they need to be sent for the new proxy. With the frame names, the FOP::operator== was concluding inequality before ever getting to compare the feature policy vector. Ian, can you confirm?
9 </body>	9 </body>

10 </html>	10 </html>

11	11

OLD	NEW

« no previous file with comments | « content/common/frame_owner_properties.cc ('k') | no next file » | no next file with comments »