Add multi line to Tabular Context Menu

Add multi line to Tabular Context Menu

This will let the user see the rest of the header text when clicking on
the textview. This also adds a test case so that way we know it works
well.

BUG=655359
Review-Url: https://codereview.chromium.org/2775393002
Cr-Commit-Position: refs/heads/master@{#460778}
Committed: https://chromium.googlesource.com/chromium/src/+/9da055f6be5c0e37d9bab627182d957d64e605de

[JJ, 2017-03-27 20:51:21]

jwanda@chromium.org changed reviewers:
+ twellington@chromium.org

[JJ, 2017-03-27 20:51:21]

Again when you have the time. The actual code is short. (17 lines) it's just the
test code that makes it look linger than it is.

[Theresa, 2017-03-27 21:22:15]

lgtm

https://codereview.chromium.org/2775393002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/contextmenu/TabularContextMenuUi.java
(right):

https://codereview.chromium.org/2775393002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/contextmenu/TabularContextMenuUi.java:38:
private boolean mMultiLineHeight;
nit: This should be something like "mIsHeaderTextExpanded" or something like
that so that it's clear it's referring to the header text.

[JJ, 2017-03-27 23:01:26]

Thanks!

https://codereview.chromium.org/2775393002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/contextmenu/TabularContextMenuUi.java
(right):

https://codereview.chromium.org/2775393002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/contextmenu/TabularContextMenuUi.java:38:
private boolean mMultiLineHeight;
On 2017/03/27 21:22:15, Theresa wrote:
> nit: This should be something like "mIsHeaderTextExpanded" or something like
> that so that it's clear it's referring to the header text.

Done.

[JJ, 2017-03-28 17:13:30]

jwanda@chromium.org changed reviewers:
+ dtrainor@chromium.org

[JJ, 2017-03-28 17:13:31]

dtrainor@chromium.org: Please review changes in 

these two simple files.

[David Trainor- moved to gerrit, 2017-03-28 19:01:23]

lgtm

[JJ, 2017-03-29 18:17:49]

btw I added a small change about removing a global if you feel like that's not
what you want hit me up!

[JJ, 2017-03-29 21:36:49]

The CQ bit was checked by jwanda@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-29 21:37:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-29 22:13:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-29 22:13:39]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)

[JJ, 2017-03-29 23:05:10]

The CQ bit was checked by jwanda@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-29 23:06:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-29 23:32:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-29 23:32:40]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)

[David Trainor- moved to gerrit, 2017-03-30 05:03:50]

still lgtm

[JJ, 2017-03-30 15:11:43]

The CQ bit was checked by jwanda@chromium.org

[JJ, 2017-03-30 15:11:43]

The patchset sent to the CQ was uploaded after l-g-t-m from
twellington@chromium.org, dtrainor@chromium.org
Link to the patchset: https://codereview.chromium.org/2775393002/#ps100001
(title: "git rebase")

[commit-bot: I haz the power, 2017-03-30 15:12:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-30 15:54:11]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1490886703120860,
"parent_rev": "ab54cdb919180001d62c8ef039e6292cac48d659", "commit_rev":
"9da055f6be5c0e37d9bab627182d957d64e605de"}

[commit-bot: I haz the power, 2017-03-30 15:55:08]

Description was changed from

==========
Add multi line to Tabular Context Menu

This will let the user see the rest of the header text when clicking on
the textview. This also adds a test case so that way we know it works
well.

BUG=655359
==========

to

==========
Add multi line to Tabular Context Menu

This will let the user see the rest of the header text when clicking on
the textview. This also adds a test case so that way we know it works
well.

BUG=655359

Review-Url: https://codereview.chromium.org/2775393002
Cr-Commit-Position: refs/heads/master@{#460778}
Committed:
https://chromium.googlesource.com/chromium/src/+/9da055f6be5c0e37d9bab627182d...
==========

[commit-bot: I haz the power, 2017-03-30 15:55:09]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/9da055f6be5c0e37d9bab627182d...