third_party/WebKit/Source/modules/payments/PaymentInstrument.idl - Issue 2775343002: PaymentHandler: Initial implementation for PaymentInstruments.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/modules/payments/PaymentInstrument.idl

Issue 2775343002: PaymentHandler: Initial implementation for PaymentInstruments. (Closed)

Patch Set: PaymentHandler: Initial implementation for PaymentInstruments. Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2017 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 // https://w3c.github.io/webpayments-payment-apps-api/#payment-instrument

	6

	7 dictionary PaymentInstrument {
	please use gerrit instead 2017/03/28 16:33:29 Let's put the RuntimeEnabled=PaymentApp in here ju Let's put the RuntimeEnabled=PaymentApp in here just for clarity. zino 2017/03/29 15:51:23 Is it possible? I didn't find any case of use. As Show quoted text On 2017/03/28 16:33:29, ಠ_ಠ wrote: > Let's put the RuntimeEnabled=PaymentApp in here just for clarity. Is it possible? I didn't find any case of use. As far as I know, the dictionary only needs the flag for member attributes. Related CL link: https://codereview.chromium.org/1412433004
	8 required DOMString name;

	9 // TODO(zino): sequence<ImageObject> icons;
	please use gerrit instead 2017/03/28 16:33:29 Why comment this out? Why comment this out? zino 2017/03/29 15:51:23 The icons is not be clear yet. There is no ImageOb Show quoted text On 2017/03/28 16:33:29, ಠ_ಠ wrote: > Why comment this out? The icons is not be clear yet. There is no ImageObject in IDL level. Instead we should use string or define another interface. Related link: - https://github.com/w3c/webpayments-payment-apps-api/issues/69 I'll leave a comment in more detail.
	10 sequence<DOMString> enabledMethods;

	11 object capabilities;

	12 };

OLD	NEW