Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1412433004: bindings: Generation of dictionary IDLs with RuntimeEnabled attributes. (Closed)

Created:
5 years, 2 months ago by dtapuska
Modified:
5 years, 2 months ago
Reviewers:
haraken, bashi
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org, Rick Byers
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

bindings: Generation of dictionary IDLs with RuntimeEnabled attributes. Add support to be able to generate dictionaries with RuntimeEnabled attributes. BUG=441569 Committed: https://crrev.com/808b9d1720ec46fc54f4136506e52bfabeb1993d Cr-Commit-Position: refs/heads/master@{#354769}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -0 lines) Patch
M third_party/WebKit/Source/bindings/scripts/v8_dictionary.py View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/templates/dictionary_v8.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/idls/core/TestDictionary.idl View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/TestDictionary.h View 2 chunks +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestDictionary.cpp View 2 chunks +21 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
dtapuska
5 years, 2 months ago (2015-10-16 18:05:37 UTC) #3
haraken
LGTM, bashi@ should confirm.
5 years, 2 months ago (2015-10-17 02:25:17 UTC) #4
bashi
lgtm
5 years, 2 months ago (2015-10-19 02:59:32 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1412433004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1412433004/1
5 years, 2 months ago (2015-10-19 13:28:00 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-19 14:34:16 UTC) #8
commit-bot: I haz the power
5 years, 2 months ago (2015-10-19 14:35:20 UTC) #9
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/808b9d1720ec46fc54f4136506e52bfabeb1993d
Cr-Commit-Position: refs/heads/master@{#354769}

Powered by Google App Engine
This is Rietveld 408576698