bluetooth: Update services, characteristics, and descriptors

bluetooth: Update services, characteristics, and descriptors

4 new services were updated from [1]
 - fitness_machine
 - http_proxy
 - object_transfer
 - transport_discovery

1 characteristic was changed from previous map.
- intermediate_blood_pressure -> intermediate_cuff_pressure

34 new characteristics were updated from [2]
 - cross_trainer_data
 - fitness_machine_control_point
 - fitness_machine_feature
 - fitness_machine_status
 - http_control_point
 - http_entity_body
 - http_headers
 - http_status_code
 - https_security
 - indoor_bike_data
 - object_action_control_point
 - object_changed
 - object_first_created
 - object_id
 - object_last_modified
 - object_list_control_point
 - object_list_filter
 - object_name
 - object_properties
 - object_size
 - ots_feature
 - resolvable_private_address_only
 - rower_data
 - stair_climber_data
 - step_climber_data
 - supported_heart_rate_range
 - supported_inclination_range
 - supported_power_range
 - supported_resistance_level_range
 - supported_speed_range
 - tds_control_point
 - training_status
 - treadmill_data
 - uri

2 new descriptors were updated from [3]
 - number_of_digitals
 - time_trigger_setting

Also we've updated page address for Service, Characteristics
and Descriptors specified by the Bluetooth SIG.

[1] https://www.bluetooth.com/specifications/gatt/services
[2] https://www.bluetooth.com/specifications/gatt/characteristics
[3] https://www.bluetooth.com/specifications/gatt/descriptors

BUG=517115
Review-Url: https://codereview.chromium.org/2775283003
Cr-Commit-Position: refs/heads/master@{#462421}
Committed: https://chromium.googlesource.com/chromium/src/+/8deebddfd6875aa12740eb2060a3e3f760116ea5

[deejay, 2017-03-28 14:42:59]

Description was changed from

==========
bluetooth: Update services, characteristics, and descriptors

4 new services were updated from [1]
 - fitness_machine
 - http_proxy
 - object_transfer
 - transport_discovery

34 new characteristics were updated from [2]
 - cross_trainer_data
 - fitness_machine_control_point
 - fitness_machine_feature
 - fitness_machine_status
 - http_control_point
 - http_entity_body
 - http_headers
 - http_status_code
 - https_security
 - indoor_bike_data
 - object_action_control_point
 - object_changed
 - object_first_created
 - object_id
 - object_last_modified
 - object_list_control_point
 - object_list_filter
 - object_name
 - object_properties
 - object_size
 - ots_feature
 - resolvable_private_address_only
 - rower_data
 - stair_climber_data
 - step_climber_data
 - supported_heart_rate_range
 - supported_inclination_range
 - supported_power_range
 - supported_resistance_level_range
 - supported_speed_range
 - tds_control_point
 - training_status
 - treadmill_data
 - uri

2 new descriptors were updated from [3]
 - number_of_digitals
 - time_trigger_setting

[1] https://www.bluetooth.com/specifications/gatt/services
[2] https://www.bluetooth.com/specifications/gatt/characteristics
[3] https://www.bluetooth.com/specifications/gatt/descriptors

BUG=517115
==========

to

==========
bluetooth: Update services, characteristics, and descriptors

4 new services were updated from [1]
 - fitness_machine
 - http_proxy
 - object_transfer
 - transport_discovery

34 new characteristics were updated from [2]
 - cross_trainer_data
 - fitness_machine_control_point
 - fitness_machine_feature
 - fitness_machine_status
 - http_control_point
 - http_entity_body
 - http_headers
 - http_status_code
 - https_security
 - indoor_bike_data
 - object_action_control_point
 - object_changed
 - object_first_created
 - object_id
 - object_last_modified
 - object_list_control_point
 - object_list_filter
 - object_name
 - object_properties
 - object_size
 - ots_feature
 - resolvable_private_address_only
 - rower_data
 - stair_climber_data
 - step_climber_data
 - supported_heart_rate_range
 - supported_inclination_range
 - supported_power_range
 - supported_resistance_level_range
 - supported_speed_range
 - tds_control_point
 - training_status
 - treadmill_data
 - uri

2 new descriptors were updated from [3]
 - number_of_digitals
 - time_trigger_setting

[1] https://www.bluetooth.com/specifications/gatt/services
[2] https://www.bluetooth.com/specifications/gatt/characteristics
[3] https://www.bluetooth.com/specifications/gatt/descriptors

BUG=517115
==========

[deejay, 2017-03-28 14:42:59]

djmix.kim@samsung.com changed reviewers:
+ jyasskin@chromium.org, ortuno@chromium.org, scheib@chromium.org

[deejay, 2017-03-28 14:44:05]

Dear scheib,
Please take a look this patch

[ortuno, 2017-03-28 20:01:00]

Thanks for doing this! Could you keep the current order by UUID rather than
alphabetically?

[deejay, 2017-03-29 01:07:32]

On 2017/03/28 20:01:00, ortuno wrote:
> Thanks for doing this! Could you keep the current order by UUID rather than
> alphabetically?

Hi ortuno, thanks for reviewing!

I have a question.
Specially in case of characteristic that was already ordered by alphabetically
and also contained many items, 
it hard to find new added feature when we comparing with bluetooth spec(i.e
https://www.bluetooth.com/specifications/gatt/characteristics), 
if we re-order by UUID. 

Is it OK?

[deejay, 2017-03-29 01:21:24]

Description was changed from

==========
bluetooth: Update services, characteristics, and descriptors

4 new services were updated from [1]
 - fitness_machine
 - http_proxy
 - object_transfer
 - transport_discovery

34 new characteristics were updated from [2]
 - cross_trainer_data
 - fitness_machine_control_point
 - fitness_machine_feature
 - fitness_machine_status
 - http_control_point
 - http_entity_body
 - http_headers
 - http_status_code
 - https_security
 - indoor_bike_data
 - object_action_control_point
 - object_changed
 - object_first_created
 - object_id
 - object_last_modified
 - object_list_control_point
 - object_list_filter
 - object_name
 - object_properties
 - object_size
 - ots_feature
 - resolvable_private_address_only
 - rower_data
 - stair_climber_data
 - step_climber_data
 - supported_heart_rate_range
 - supported_inclination_range
 - supported_power_range
 - supported_resistance_level_range
 - supported_speed_range
 - tds_control_point
 - training_status
 - treadmill_data
 - uri

2 new descriptors were updated from [3]
 - number_of_digitals
 - time_trigger_setting

[1] https://www.bluetooth.com/specifications/gatt/services
[2] https://www.bluetooth.com/specifications/gatt/characteristics
[3] https://www.bluetooth.com/specifications/gatt/descriptors

BUG=517115
==========

to

==========
bluetooth: Update services, characteristics, and descriptors

4 new services were updated from [1]
 - fitness_machine
 - http_proxy
 - object_transfer
 - transport_discovery

34 new characteristics were updated from [2]
 - cross_trainer_data
 - fitness_machine_control_point
 - fitness_machine_feature
 - fitness_machine_status
 - http_control_point
 - http_entity_body
 - http_headers
 - http_status_code
 - https_security
 - indoor_bike_data
 - object_action_control_point
 - object_changed
 - object_first_created
 - object_id
 - object_last_modified
 - object_list_control_point
 - object_list_filter
 - object_name
 - object_properties
 - object_size
 - ots_feature
 - resolvable_private_address_only
 - rower_data
 - stair_climber_data
 - step_climber_data
 - supported_heart_rate_range
 - supported_inclination_range
 - supported_power_range
 - supported_resistance_level_range
 - supported_speed_range
 - tds_control_point
 - training_status
 - treadmill_data
 - uri

2 new descriptors were updated from [3]
 - number_of_digitals
 - time_trigger_setting

Also we've updated page address for Service, Characteristics
and Descriptors specified by the Bluetooth SIG.

[1] https://www.bluetooth.com/specifications/gatt/services
[2] https://www.bluetooth.com/specifications/gatt/characteristics
[3] https://www.bluetooth.com/specifications/gatt/descriptors

BUG=517115
==========

[ortuno, 2017-03-29 21:00:32]

Fair point. For the sake of consistency could you check that services and
descriptors are also ordered alphabetically. It would be much appreciated if you
could split this in two CLs: one for reorder and then one for new attributes or
one for new attributes and then one to reorder. That was its easier to see what
new attributes are being added.

https://codereview.chromium.org/2775283003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/bluetooth/BluetoothUUID.cpp (right):

https://codereview.chromium.org/2775283003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/bluetooth/BluetoothUUID.cpp:296:
descriptors->add("gatt.server_characteristic_configuration", 0x2903);
I think this belongs further up.

[deejay, 2017-03-30 16:22:35]

On 2017/03/29 21:00:32, ortuno wrote:
> Fair point. For the sake of consistency could you check that services and
> descriptors are also ordered alphabetically. It would be much appreciated if
you
> could split this in two CLs: one for reorder and then one for new attributes
or
> one for new attributes and then one to reorder. That was its easier to see
what
> new attributes are being added.
> 
OK I see. I will upload re-ordering patch after landing current patch.

>
https://codereview.chromium.org/2775283003/diff/20001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/modules/bluetooth/BluetoothUUID.cpp (right):
> 
>
https://codereview.chromium.org/2775283003/diff/20001/third_party/WebKit/Sour...
> third_party/WebKit/Source/modules/bluetooth/BluetoothUUID.cpp:296:
> descriptors->add("gatt.server_characteristic_configuration", 0x2903);
> I think this belongs further up.
Done.

[ortuno, 2017-03-30 23:28:28]

Patch is looking good though I think you need to rebase since add was changed to
insert.

[deejay, 2017-04-01 16:23:55]

On 2017/03/30 23:28:28, ortuno wrote:
> Patch is looking good though I think you need to rebase since add was changed
to
> insert.

Now I've rebased with latest code.

[ortuno, 2017-04-03 03:41:12]

I don't think you rebased. The patch still has uses "add" whereas most recent
code uses "insert":

https://cs.chromium.org/chromium/src/third_party/WebKit/Source/modules/blueto...

Feel free to post the commands you are running here if you run into any
problems. Also you can ask on #chromium.

[deejay, 2017-04-05 05:27:13]

On 2017/04/03 03:41:12, ortuno wrote:
> I don't think you rebased. The patch still has uses "add" whereas most recent
> code uses "insert":
> 
>
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/modules/blueto...
> 
> Feel free to post the commands you are running here if you run into any
> problems. Also you can ask on #chromium.

Oh, I got it! I've update with latest code. Now it use "insert" instead of
"add".

[ortuno, 2017-04-05 07:26:25]

https://codereview.chromium.org/2775283003/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/bluetooth/BluetoothUUID.cpp (left):

https://codereview.chromium.org/2775283003/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/bluetooth/BluetoothUUID.cpp:251:
descriptors->insert("gatt.characteristic_presentation_format", 0x2904);
As discussed let's reorder the values in a separate patch and keep this patch
only about adding new values.

[deejay, 2017-04-05 08:09:26]

https://codereview.chromium.org/2775283003/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/bluetooth/BluetoothUUID.cpp (left):

https://codereview.chromium.org/2775283003/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/bluetooth/BluetoothUUID.cpp:251:
descriptors->insert("gatt.characteristic_presentation_format", 0x2904);
On 2017/04/05 07:26:25, ortuno wrote:
> As discussed let's reorder the values in a separate patch and keep this patch
> only about adding new values.

Done.

[ortuno, 2017-04-06 03:11:00]

lgtm bar one small thing

https://codereview.chromium.org/2775283003/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/bluetooth/BluetoothUUID.cpp (right):

https://codereview.chromium.org/2775283003/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/bluetooth/BluetoothUUID.cpp:168:
characteristics->insert("intermediate_blood_pressure", 0x2A36);
Seems this characteristic was changed to intermediate_cuff_pressure. So let's
update that here as well.

[ortuno, 2017-04-06 03:11:06]

The CQ bit was checked by ortuno@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-06 03:11:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[deejay, 2017-04-06 04:30:43]

https://codereview.chromium.org/2775283003/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/bluetooth/BluetoothUUID.cpp (right):

https://codereview.chromium.org/2775283003/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/bluetooth/BluetoothUUID.cpp:168:
characteristics->insert("intermediate_blood_pressure", 0x2A36);
On 2017/04/06 03:11:00, ortuno wrote:
> Seems this characteristic was changed to intermediate_cuff_pressure. So let's
> update that here as well.

Thanks for checking. I will update it.

[deejay, 2017-04-06 04:35:45]

Description was changed from

==========
bluetooth: Update services, characteristics, and descriptors

4 new services were updated from [1]
 - fitness_machine
 - http_proxy
 - object_transfer
 - transport_discovery

34 new characteristics were updated from [2]
 - cross_trainer_data
 - fitness_machine_control_point
 - fitness_machine_feature
 - fitness_machine_status
 - http_control_point
 - http_entity_body
 - http_headers
 - http_status_code
 - https_security
 - indoor_bike_data
 - object_action_control_point
 - object_changed
 - object_first_created
 - object_id
 - object_last_modified
 - object_list_control_point
 - object_list_filter
 - object_name
 - object_properties
 - object_size
 - ots_feature
 - resolvable_private_address_only
 - rower_data
 - stair_climber_data
 - step_climber_data
 - supported_heart_rate_range
 - supported_inclination_range
 - supported_power_range
 - supported_resistance_level_range
 - supported_speed_range
 - tds_control_point
 - training_status
 - treadmill_data
 - uri

2 new descriptors were updated from [3]
 - number_of_digitals
 - time_trigger_setting

Also we've updated page address for Service, Characteristics
and Descriptors specified by the Bluetooth SIG.

[1] https://www.bluetooth.com/specifications/gatt/services
[2] https://www.bluetooth.com/specifications/gatt/characteristics
[3] https://www.bluetooth.com/specifications/gatt/descriptors

BUG=517115
==========

to

==========
bluetooth: Update services, characteristics, and descriptors

4 new services were updated from [1]
 - fitness_machine
 - http_proxy
 - object_transfer
 - transport_discovery

1 characteristic was changed from previous map.
- intermediate_blood_pressure -> intermediate_cuff_pressure

34 new characteristics were updated from [2]
 - cross_trainer_data
 - fitness_machine_control_point
 - fitness_machine_feature
 - fitness_machine_status
 - http_control_point
 - http_entity_body
 - http_headers
 - http_status_code
 - https_security
 - indoor_bike_data
 - object_action_control_point
 - object_changed
 - object_first_created
 - object_id
 - object_last_modified
 - object_list_control_point
 - object_list_filter
 - object_name
 - object_properties
 - object_size
 - ots_feature
 - resolvable_private_address_only
 - rower_data
 - stair_climber_data
 - step_climber_data
 - supported_heart_rate_range
 - supported_inclination_range
 - supported_power_range
 - supported_resistance_level_range
 - supported_speed_range
 - tds_control_point
 - training_status
 - treadmill_data
 - uri

2 new descriptors were updated from [3]
 - number_of_digitals
 - time_trigger_setting

Also we've updated page address for Service, Characteristics
and Descriptors specified by the Bluetooth SIG.

[1] https://www.bluetooth.com/specifications/gatt/services
[2] https://www.bluetooth.com/specifications/gatt/characteristics
[3] https://www.bluetooth.com/specifications/gatt/descriptors

BUG=517115
==========

[deejay, 2017-04-06 04:36:47]

The CQ bit was checked by djmix.kim@samsung.com

[deejay, 2017-04-06 04:36:48]

The patchset sent to the CQ was uploaded after l-g-t-m from ortuno@chromium.org
Link to the patchset: https://codereview.chromium.org/2775283003/#ps120001
(title: "Update to "intermediate_cuff_pressure"")

[commit-bot: I haz the power, 2017-04-06 04:37:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-06 06:25:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-06 06:25:55]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[deejay, 2017-04-06 09:57:51]

On 2017/04/06 06:25:55, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

Dear reviewer,
It was my fault. 
Now I've checked layout/unit tests for bluetooth, it works fine.

[deejay, 2017-04-06 09:58:01]

The CQ bit was checked by djmix.kim@samsung.com

[deejay, 2017-04-06 09:58:01]

The patchset sent to the CQ was uploaded after l-g-t-m from ortuno@chromium.org
Link to the patchset: https://codereview.chromium.org/2775283003/#ps160001
(title: "fix layout_test errors #2")

[commit-bot: I haz the power, 2017-04-06 09:58:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-06 11:16:34]

CQ is committing da patch.

Bot data: {"patchset_id": 160001, "attempt_start_ts": 1491472681081110,
"parent_rev": "b6ba28d755eb8cbcc5dba2f414d10cd2e434f6d8", "commit_rev":
"8deebddfd6875aa12740eb2060a3e3f760116ea5"}

[commit-bot: I haz the power, 2017-04-06 11:17:22]

Description was changed from

==========
bluetooth: Update services, characteristics, and descriptors

4 new services were updated from [1]
 - fitness_machine
 - http_proxy
 - object_transfer
 - transport_discovery

1 characteristic was changed from previous map.
- intermediate_blood_pressure -> intermediate_cuff_pressure

34 new characteristics were updated from [2]
 - cross_trainer_data
 - fitness_machine_control_point
 - fitness_machine_feature
 - fitness_machine_status
 - http_control_point
 - http_entity_body
 - http_headers
 - http_status_code
 - https_security
 - indoor_bike_data
 - object_action_control_point
 - object_changed
 - object_first_created
 - object_id
 - object_last_modified
 - object_list_control_point
 - object_list_filter
 - object_name
 - object_properties
 - object_size
 - ots_feature
 - resolvable_private_address_only
 - rower_data
 - stair_climber_data
 - step_climber_data
 - supported_heart_rate_range
 - supported_inclination_range
 - supported_power_range
 - supported_resistance_level_range
 - supported_speed_range
 - tds_control_point
 - training_status
 - treadmill_data
 - uri

2 new descriptors were updated from [3]
 - number_of_digitals
 - time_trigger_setting

Also we've updated page address for Service, Characteristics
and Descriptors specified by the Bluetooth SIG.

[1] https://www.bluetooth.com/specifications/gatt/services
[2] https://www.bluetooth.com/specifications/gatt/characteristics
[3] https://www.bluetooth.com/specifications/gatt/descriptors

BUG=517115
==========

to

==========
bluetooth: Update services, characteristics, and descriptors

4 new services were updated from [1]
 - fitness_machine
 - http_proxy
 - object_transfer
 - transport_discovery

1 characteristic was changed from previous map.
- intermediate_blood_pressure -> intermediate_cuff_pressure

34 new characteristics were updated from [2]
 - cross_trainer_data
 - fitness_machine_control_point
 - fitness_machine_feature
 - fitness_machine_status
 - http_control_point
 - http_entity_body
 - http_headers
 - http_status_code
 - https_security
 - indoor_bike_data
 - object_action_control_point
 - object_changed
 - object_first_created
 - object_id
 - object_last_modified
 - object_list_control_point
 - object_list_filter
 - object_name
 - object_properties
 - object_size
 - ots_feature
 - resolvable_private_address_only
 - rower_data
 - stair_climber_data
 - step_climber_data
 - supported_heart_rate_range
 - supported_inclination_range
 - supported_power_range
 - supported_resistance_level_range
 - supported_speed_range
 - tds_control_point
 - training_status
 - treadmill_data
 - uri

2 new descriptors were updated from [3]
 - number_of_digitals
 - time_trigger_setting

Also we've updated page address for Service, Characteristics
and Descriptors specified by the Bluetooth SIG.

[1] https://www.bluetooth.com/specifications/gatt/services
[2] https://www.bluetooth.com/specifications/gatt/characteristics
[3] https://www.bluetooth.com/specifications/gatt/descriptors

BUG=517115

Review-Url: https://codereview.chromium.org/2775283003
Cr-Commit-Position: refs/heads/master@{#462421}
Committed:
https://chromium.googlesource.com/chromium/src/+/8deebddfd6875aa12740eb2060a3...
==========

[commit-bot: I haz the power, 2017-04-06 11:17:23]

Committed patchset #9 (id:160001) as
https://chromium.googlesource.com/chromium/src/+/8deebddfd6875aa12740eb2060a3...