Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(421)

Issue 2775233003: Accessibility: Fix color enhancer filtering (Closed)

Created:
3 years, 8 months ago by Peter Wen
Modified:
3 years, 8 months ago
Reviewers:
dmazzoni
CC:
chromium-reviews, extensions-reviews_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, dougt+watch_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, chromium-apps-reviews_chromium.org, je_julie
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Accessibility: Fix color enhancer filtering Chrome no longer updates the filter unless it is fixed positioned. BUG=701521 Review-Url: https://codereview.chromium.org/2775233003 Cr-Commit-Position: refs/heads/master@{#460437} Committed: https://chromium.googlesource.com/chromium/src/+/58584e833494875506a8bf21df00022ff21db495

Patch Set 1 #

Patch Set 2 : Fix build rule #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -41 lines) Patch
M ui/accessibility/extensions/BUILD.gn View 1 1 chunk +0 lines, -1 line 0 comments Download
M ui/accessibility/extensions/colorenhancer/manifest.json View 2 1 chunk +1 line, -1 line 0 comments Download
D ui/accessibility/extensions/colorenhancer/res/cvd.css View 2 1 chunk +0 lines, -11 lines 0 comments Download
M ui/accessibility/extensions/colorenhancer/src/background.js View 1 chunk +0 lines, -3 lines 0 comments Download
M ui/accessibility/extensions/colorenhancer/src/cvd.js View 2 3 chunks +47 lines, -25 lines 0 comments Download

Messages

Total messages: 23 (14 generated)
Peter Wen
Turns out the fixed positioning was all that was required... reverted all the background stuff ...
3 years, 8 months ago (2017-03-27 18:04:10 UTC) #2
dmazzoni
lgtm
3 years, 8 months ago (2017-03-28 17:32:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2775233003/1
3 years, 8 months ago (2017-03-29 13:07:51 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_ng/builds/265634)
3 years, 8 months ago (2017-03-29 13:13:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2775233003/1
3 years, 8 months ago (2017-03-29 14:28:31 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2775233003/20001
3 years, 8 months ago (2017-03-29 14:30:05 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-clang/builds/65052) ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, ...
3 years, 8 months ago (2017-03-29 14:32:09 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2775233003/40001
3 years, 8 months ago (2017-03-29 16:09:46 UTC) #20
commit-bot: I haz the power
3 years, 8 months ago (2017-03-29 17:26:17 UTC) #23
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/58584e833494875506a8bf21df00...

Powered by Google App Engine
This is Rietveld 408576698