Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issue 2775193005: Fix display resolution label (Closed)

Created:
3 years, 9 months ago by stevenjb
Modified:
3 years, 8 months ago
Reviewers:
malaykeshav
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix display resolution label The variable was renamed in the JS but not in the HTML. We also want to show the slider value as it changes, not the current value. BUG=704804 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2775193005 Cr-Commit-Position: refs/heads/master@{#461228} Committed: https://chromium.googlesource.com/chromium/src/+/b1ddcc1554736619ccfc93a850f6a27fb1be8158

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/resources/settings/device_page/display.html View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (6 generated)
stevenjb
3 years, 8 months ago (2017-03-31 18:37:17 UTC) #4
malaykeshav
lgtm
3 years, 8 months ago (2017-03-31 18:45:40 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2775193005/20001
3 years, 8 months ago (2017-03-31 18:46:18 UTC) #7
commit-bot: I haz the power
3 years, 8 months ago (2017-03-31 21:08:37 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/b1ddcc1554736619ccfc93a850f6...

Powered by Google App Engine
This is Rietveld 408576698