[Payments] Have an observer for canMakePayment, for testing.

[Payments] Have an observer for canMakePayment, for testing.

BUG=705271
TEST=browser_tests

Review-Url: https://codereview.chromium.org/2775193004
Cr-Commit-Position: refs/heads/master@{#459852}
Committed: https://chromium.googlesource.com/chromium/src/+/300fa54be51e2d3969e11937e5e8ed97d546bfac

[Mathieu, 2017-03-27 16:34:41]

The CQ bit was checked by mathp@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-27 16:35:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Mathieu, 2017-03-27 16:52:24]

The CQ bit was checked by mathp@chromium.org to run a CQ dry run

[Mathieu, 2017-03-27 16:52:34]

mathp@chromium.org changed reviewers:
+ rouslan@chromium.org

[Mathieu, 2017-03-27 16:52:34]

Rouslan PTAL?

[commit-bot: I haz the power, 2017-03-27 16:52:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-27 17:44:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-27 17:44:54]

Dry run: This issue passed the CQ dry run.

[please use gerrit instead, 2017-03-27 18:12:32]

LGTM % nits

https://codereview.chromium.org/2775193004/diff/20001/chrome/browser/ui/views...
File
chrome/browser/ui/views/payments/payment_request_can_make_payment_browsertest.cc
(right):

https://codereview.chromium.org/2775193004/diff/20001/chrome/browser/ui/views...
chrome/browser/ui/views/payments/payment_request_can_make_payment_browsertest.cc:72:
CanMakePayment_NotSupported_Incognito) {
NotSupported seems like the wrong phrase. Should it be AlwaysTrue instead?

https://codereview.chromium.org/2775193004/diff/20001/components/payments/con...
File components/payments/content/payment_request.h (right):

https://codereview.chromium.org/2775193004/diff/20001/components/payments/con...
components/payments/content/payment_request.h:39: virtual void
OnCanMakePaymentCalled() = 0;
Need a virtual empty destructor.

https://codereview.chromium.org/2775193004/diff/20001/components/payments/con...
components/payments/content/payment_request.h:96: // May be null.
, must outlive this object.

[Mathieu, 2017-03-27 18:28:24]

Thanks

https://codereview.chromium.org/2775193004/diff/20001/chrome/browser/ui/views...
File
chrome/browser/ui/views/payments/payment_request_can_make_payment_browsertest.cc
(right):

https://codereview.chromium.org/2775193004/diff/20001/chrome/browser/ui/views...
chrome/browser/ui/views/payments/payment_request_can_make_payment_browsertest.cc:72:
CanMakePayment_NotSupported_Incognito) {
On 2017/03/27 18:12:32, ಠ_ಠ wrote:
> NotSupported seems like the wrong phrase. Should it be AlwaysTrue instead?

It's the name of the test case. We are calling CanMakePayment, payment is
NotSupported, and we are in Incognito.

I've added a description as to what is the test expectation.

https://codereview.chromium.org/2775193004/diff/20001/components/payments/con...
File components/payments/content/payment_request.h (right):

https://codereview.chromium.org/2775193004/diff/20001/components/payments/con...
components/payments/content/payment_request.h:39: virtual void
OnCanMakePaymentCalled() = 0;
On 2017/03/27 18:12:32, ಠ_ಠ wrote:
> Need a virtual empty destructor.

Done.

https://codereview.chromium.org/2775193004/diff/20001/components/payments/con...
components/payments/content/payment_request.h:96: // May be null.
On 2017/03/27 18:12:32, ಠ_ಠ wrote:
> , must outlive this object.

Done.

[Mathieu, 2017-03-27 18:28:31]

The CQ bit was checked by mathp@chromium.org

[Mathieu, 2017-03-27 18:28:32]

The patchset sent to the CQ was uploaded after l-g-t-m from rouslan@chromium.org
Link to the patchset: https://codereview.chromium.org/2775193004/#ps40001
(title: "addressed comments")

[commit-bot: I haz the power, 2017-03-27 18:29:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-27 19:29:41]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1490639311709310,
"parent_rev": "ee2be6e582be6b73f96eb7caf150e57fb1817dc4", "commit_rev":
"300fa54be51e2d3969e11937e5e8ed97d546bfac"}

[commit-bot: I haz the power, 2017-03-27 19:30:26]

Description was changed from

==========
[Payments] Have an observer for canMakePayment, for testing.

BUG=705271
TEST=browser_tests
==========

to

==========
[Payments] Have an observer for canMakePayment, for testing.

BUG=705271
TEST=browser_tests

Review-Url: https://codereview.chromium.org/2775193004
Cr-Commit-Position: refs/heads/master@{#459852}
Committed:
https://chromium.googlesource.com/chromium/src/+/300fa54be51e2d3969e11937e5e8...
==========

[commit-bot: I haz the power, 2017-03-27 19:30:28]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/300fa54be51e2d3969e11937e5e8...