Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2775173003:
Add integration test for QUIC with non core proxies (Closed)
DescriptionAdd integration test for QUIC with non core proxies
Other minor changes:
1. Separate out QUIC tests to quic.py.
2. Separate out QUIC test in two different tests.
3. Add chrome arg --data-reduction-proxy-enable-quic-on-non-core-proxies
to the tests so that QUIC usage would be enabled even when Chrome is
using a non-core proxy.
BUG=663584
Review-Url: https://codereview.chromium.org/2775173003
Cr-Commit-Position: refs/heads/master@{#460474}
Committed: https://chromium.googlesource.com/chromium/src/+/02a0fe9ac80db197c640106ed6a36efbdec49e19
Patch Set 1 : ps #
Messages
Total messages: 25 (16 generated)
Patchset #1 (id:1) has been deleted
Patchset #1 (id:20001) has been deleted
Description was changed from ========== Add integration test for QUIC with non core proxies BUG= ========== to ========== Add integration test for QUIC with non core proxies Other minor changes: 1. Separate out QUIC tests to quic.py. 2. Separate out QUIC test in two different tests. 3. Add chrome arg --data-reduction-proxy-enable-quic-on-non-core-proxies to the tests so that QUIC usage would be enabled even when Chrome is using a non-core proxy. BUG= ==========
Patchset #1 (id:40001) has been deleted
Description was changed from ========== Add integration test for QUIC with non core proxies Other minor changes: 1. Separate out QUIC tests to quic.py. 2. Separate out QUIC test in two different tests. 3. Add chrome arg --data-reduction-proxy-enable-quic-on-non-core-proxies to the tests so that QUIC usage would be enabled even when Chrome is using a non-core proxy. BUG= ========== to ========== Add integration test for QUIC with non core proxies Other minor changes: 1. Separate out QUIC tests to quic.py. 2. Separate out QUIC test in two different tests. 3. Add chrome arg --data-reduction-proxy-enable-quic-on-non-core-proxies to the tests so that QUIC usage would be enabled even when Chrome is using a non-core proxy. BUG=663584 ==========
tbansal@chromium.org changed reviewers: + megjablon@chromium.org, robertogden@chromium.org
megjablon, robertogden: ptal. Thanks.
lgtm
megjablon@google.com changed reviewers: + megjablon@google.com
lgtm
The CQ bit was checked by tbansal@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a full super star committer. Committers are members of the group "project-chromium-committers". Note that this has nothing to do with OWNERS files.
The CQ bit was checked by tbansal@chromium.org to run a CQ dry run
megjablon: Can you l-g-t-m this from the Chromium account? Thanks.
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by tbansal@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 60001, "attempt_start_ts": 1490812329645740,
"parent_rev": "b0017dec5002e248c2ed120a719d7642158e69f4", "commit_rev":
"02a0fe9ac80db197c640106ed6a36efbdec49e19"}
Message was sent while issue was closed.
Description was changed from ========== Add integration test for QUIC with non core proxies Other minor changes: 1. Separate out QUIC tests to quic.py. 2. Separate out QUIC test in two different tests. 3. Add chrome arg --data-reduction-proxy-enable-quic-on-non-core-proxies to the tests so that QUIC usage would be enabled even when Chrome is using a non-core proxy. BUG=663584 ========== to ========== Add integration test for QUIC with non core proxies Other minor changes: 1. Separate out QUIC tests to quic.py. 2. Separate out QUIC test in two different tests. 3. Add chrome arg --data-reduction-proxy-enable-quic-on-non-core-proxies to the tests so that QUIC usage would be enabled even when Chrome is using a non-core proxy. BUG=663584 Review-Url: https://codereview.chromium.org/2775173003 Cr-Commit-Position: refs/heads/master@{#460474} Committed: https://chromium.googlesource.com/chromium/src/+/02a0fe9ac80db197c640106ed6a3... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:60001) as https://chromium.googlesource.com/chromium/src/+/02a0fe9ac80db197c640106ed6a3... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
