third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.h.tmpl - Issue 2775153002: Document why ComputedStyle constructor and destructor are protected.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.h.tmpl

Issue 2775153002: Document why ComputedStyle constructor and destructor are protected. (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.h.tmpl

diff --git a/third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.h.tmpl b/third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.h.tmpl

index ccdbb4711a1b58706b59d457b58e954487bbbb6a..5baf4c07819e329a017b5988ee41433da4d63875 100644

--- a/third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.h.tmpl

+++ b/third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.h.tmpl

@@ -79,6 +79,8 @@ class CORE_EXPORT ComputedStyleBase {

{% endfor %}

protected:

+ // Constructor and destructor are protected so that only the parent class ComputedStyle

+ // can instantiate this class.

ALWAYS_INLINE ComputedStyleBase() :

{% for field in fields %}

{{field.name}}(static_cast<unsigned>({{field.default_value}})){{print_if(not loop.last, ',')}}

« no previous file with comments | « no previous file | no next file » | no next file with comments »