Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issue 2775153002: Document why ComputedStyle constructor and destructor are protected. (Closed)

Created:
3 years, 9 months ago by shend
Modified:
3 years, 9 months ago
Reviewers:
sashab
CC:
blink-reviews, blink-reviews-style_chromium.org, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Document why ComputedStyle constructor and destructor are protected. In a previous patch https://codereview.chromium.org/2739553003, the constructor and destructor of ComputedStyle were moved to be protected, but it was not clear in the code why this was done. This patch adds a comment explain it. BUG=628043 Review-Url: https://codereview.chromium.org/2775153002 Cr-Commit-Position: refs/heads/master@{#459713} Committed: https://chromium.googlesource.com/chromium/src/+/eef3d4234dc4399e0b1192dd9af1e74b590d36ee

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.h.tmpl View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
shend
Hi Sasha, as promised, PTAL
3 years, 9 months ago (2017-03-27 05:00:59 UTC) #2
sashab
Love it. LGTM
3 years, 9 months ago (2017-03-27 05:06:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2775153002/1
3 years, 9 months ago (2017-03-27 05:22:18 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/348418)
3 years, 9 months ago (2017-03-27 06:11:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2775153002/1
3 years, 9 months ago (2017-03-27 06:21:42 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-27 07:18:34 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/eef3d4234dc4399e0b1192dd9af1...

Powered by Google App Engine
This is Rietveld 408576698