Conic gradient parsing support

Conic gradient parsing support

Add support for CSS Image Values Level 4 [repeating-]conic-gradient parsing,
based on https://drafts.csswg.org/css-images-4/#conic-gradients.

The feature is behind an experimental flag, pending full implementation and
shipping approval.

BUG=705991
Review-Url: https://codereview.chromium.org/2775103002
Cr-Commit-Position: refs/heads/master@{#460225}
Committed: https://chromium.googlesource.com/chromium/src/+/5893d66e0e4cc0d37332e2c4e02ba36885823ea2

[f(malita), 2017-03-27 17:35:55]

The CQ bit was checked by fmalita@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-27 17:36:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[f(malita), 2017-03-27 17:56:32]

The CQ bit was checked by fmalita@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-27 17:56:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-27 19:25:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-27 19:25:40]

Dry run: This issue passed the CQ dry run.

[f(malita), 2017-03-28 14:47:00]

The CQ bit was checked by fmalita@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-28 14:47:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[f(malita), 2017-03-28 14:51:08]

Description was changed from

==========
Conic gradient parsing

WIP

BUG=
==========

to

==========
Conic gradient parsing support

Add support for CSS Image Values Level 4 conic-gradient parsing, based on
https://drafts.csswg.org/css-images-4/#conic-gradients.

The feature is behind an experimental flag, pending full implementation and
shipping approval.

BUG=
==========

[f(malita), 2017-03-28 14:55:04]

Description was changed from

==========
Conic gradient parsing support

Add support for CSS Image Values Level 4 conic-gradient parsing, based on
https://drafts.csswg.org/css-images-4/#conic-gradients.

The feature is behind an experimental flag, pending full implementation and
shipping approval.

BUG=
==========

to

==========
Conic gradient parsing support

Add support for CSS Image Values Level 4 [repeating-]conic-gradient parsing,
based on https://drafts.csswg.org/css-images-4/#conic-gradients.

The feature is behind an experimental flag, pending full implementation and
shipping approval.

BUG=705991
==========

[f(malita), 2017-03-28 14:55:05]

fmalita@chromium.org changed reviewers:
+ fs@opera.com, schenney@chromium.org

[f(malita), 2017-03-28 15:01:35]

Parsing-only, painting to land separately.

There are likely some CSSGradient* cleanup opportunities, but I don't want to
shake things up too much in this CL - will look at it later.

[fs, 2017-03-28 15:59:20]

https://codereview.chromium.org/2775103002/diff/60001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/fast/gradients/conic-gradient-parsing.html
(right):

https://codereview.chromium.org/2775103002/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/gradients/conic-gradient-parsing.html:8:
function computedValue(css)
LayoutTests/css-parser/resources/property-parsing-test.js has some spiffy
helpers for these type of things. Might be worth reusing if possible. (Tests a
bit more things, although it actually doesn't test computed style. Doesn't look
like all of these tests need computed style though. (And specified style is also
interesting to check what it round-trips to.) We can do this as a follow-up
though.

https://codereview.chromium.org/2775103002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/CSSGradientValue.cpp (right):

https://codereview.chromium.org/2775103002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/CSSGradientValue.cpp:1372: auto
wroteSomething = false;
s/auto/bool/ - really =)

https://codereview.chromium.org/2775103002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/CSSGradientValue.cpp:1398: bool
CSSConicGradientValue::equals(const CSSConicGradientValue& other) const {
Should check at least m_repeating too I think (possibly more.)

https://codereview.chromium.org/2775103002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/CSSGradientValue.h (right):

https://codereview.chromium.org/2775103002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/CSSGradientValue.h:64:
Member<CSSPrimitiveValue> m_position;  // percentage | length | angle
(I sense that "m_offsetValue" or somesuch might be a better, more general, term
here, but we can leave that to the cleanup I suppose.)

https://codereview.chromium.org/2775103002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.cpp
(right):

https://codereview.chromium.org/2775103002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.cpp:949:
PositionFunctor consumePosition) {
There's a consumePosition defined in this file, so it might be good to use a
prefix/suffix to distinguish.

https://codereview.chromium.org/2775103002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.cpp:1167:
CSSPrimitiveValue* fromAngle = nullptr;
Let's move these closer to their first use (def).

[commit-bot: I haz the power, 2017-03-28 17:02:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-28 17:02:45]

Dry run: This issue passed the CQ dry run.

[f(malita), 2017-03-28 17:15:33]

The CQ bit was checked by fmalita@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-28 17:16:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[f(malita), 2017-03-28 17:16:45]

https://codereview.chromium.org/2775103002/diff/60001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/fast/gradients/conic-gradient-parsing.html
(right):

https://codereview.chromium.org/2775103002/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/gradients/conic-gradient-parsing.html:8:
function computedValue(css)
On 2017/03/28 15:59:20, fs wrote:
> LayoutTests/css-parser/resources/property-parsing-test.js has some spiffy
> helpers for these type of things. Might be worth reusing if possible. (Tests a
> bit more things, although it actually doesn't test computed style. Doesn't
look
> like all of these tests need computed style though. (And specified style is
also
> interesting to check what it round-trips to.) We can do this as a follow-up
> though.

Thanks for the pointer.  Updated to use that, similar to
https://cs.chromium.org/chromium/src/third_party/WebKit/LayoutTests/css3/filt...

https://codereview.chromium.org/2775103002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/CSSGradientValue.cpp (right):

https://codereview.chromium.org/2775103002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/CSSGradientValue.cpp:1372: auto
wroteSomething = false;
On 2017/03/28 15:59:20, fs wrote:
> s/auto/bool/ - really =)

Heh, it does read weird (leftover from prev patch set).

Done.

https://codereview.chromium.org/2775103002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/CSSGradientValue.cpp:1398: bool
CSSConicGradientValue::equals(const CSSConicGradientValue& other) const {
On 2017/03/28 15:59:20, fs wrote:
> Should check at least m_repeating too I think 

Good catch, done.

> (possibly more.)

Can't think of anything else at this point.

https://codereview.chromium.org/2775103002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/CSSGradientValue.h (right):

https://codereview.chromium.org/2775103002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/CSSGradientValue.h:64:
Member<CSSPrimitiveValue> m_position;  // percentage | length | angle
On 2017/03/28 15:59:20, fs wrote:
> (I sense that "m_offsetValue" or somesuch might be a better, more general,
term
> here, but we can leave that to the cleanup I suppose.)

Ack, that would touch a bunch of code.

https://codereview.chromium.org/2775103002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.cpp
(right):

https://codereview.chromium.org/2775103002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.cpp:949:
PositionFunctor consumePosition) {
On 2017/03/28 15:59:20, fs wrote:
> There's a consumePosition defined in this file, so it might be good to use a
> prefix/suffix to distinguish.

Done (consumePositionFunc).

https://codereview.chromium.org/2775103002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.cpp:1167:
CSSPrimitiveValue* fromAngle = nullptr;
On 2017/03/28 15:59:20, fs wrote:
> Let's move these closer to their first use (def).

Done.

[fs, 2017-03-28 18:02:09]

lgtm

[commit-bot: I haz the power, 2017-03-28 19:03:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-28 19:03:56]

Dry run: This issue passed the CQ dry run.

[f(malita), 2017-03-28 22:03:38]

The CQ bit was checked by fmalita@chromium.org

[commit-bot: I haz the power, 2017-03-28 22:03:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-28 22:30:59]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1490738618676820,
"parent_rev": "d04d3a25c0615e015c3d8cb603ccab0081e350df", "commit_rev":
"5893d66e0e4cc0d37332e2c4e02ba36885823ea2"}

[commit-bot: I haz the power, 2017-03-28 22:31:52]

Description was changed from

==========
Conic gradient parsing support

Add support for CSS Image Values Level 4 [repeating-]conic-gradient parsing,
based on https://drafts.csswg.org/css-images-4/#conic-gradients.

The feature is behind an experimental flag, pending full implementation and
shipping approval.

BUG=705991
==========

to

==========
Conic gradient parsing support

Add support for CSS Image Values Level 4 [repeating-]conic-gradient parsing,
based on https://drafts.csswg.org/css-images-4/#conic-gradients.

The feature is behind an experimental flag, pending full implementation and
shipping approval.

BUG=705991

Review-Url: https://codereview.chromium.org/2775103002
Cr-Commit-Position: refs/heads/master@{#460225}
Committed:
https://chromium.googlesource.com/chromium/src/+/5893d66e0e4cc0d37332e2c4e02b...
==========

[commit-bot: I haz the power, 2017-03-28 22:31:54]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/5893d66e0e4cc0d37332e2c4e02b...