Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 2775083002: Update conditional in BrowserNonClientFrameView::DoesIntersectRect. (Closed)

Created:
3 years, 9 months ago by Bret
Modified:
3 years, 8 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews, tfarina
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Update conditional in BrowserNonClientFrameView::DoesIntersectRect. As per crrev.com/2283253002#msg37 this patch updates one of the conditional branches BrowserNonClientFrameView::DoesIntersectRect to return true if a large hit-test rectangle overlaps both the tabstrip and the client area. Review-Url: https://codereview.chromium.org/2775083002 Cr-Commit-Position: refs/heads/master@{#460511} Committed: https://chromium.googlesource.com/chromium/src/+/c1036c002f34914a521b631d57b8c7bdd01f4ce3

Patch Set 1 #

Patch Set 2 : change test names #

Patch Set 3 : fix test on cros #

Total comments: 2

Patch Set 4 : edit comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -4 lines) Patch
M chrome/browser/ui/views/frame/browser_non_client_frame_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/browser_non_client_frame_view_unittest.cc View 1 2 3 3 chunks +38 lines, -3 lines 0 comments Download

Messages

Total messages: 17 (12 generated)
Bret
3 years, 8 months ago (2017-03-29 01:26:07 UTC) #9
Peter Kasting
LGTM https://codereview.chromium.org/2775083002/diff/40001/chrome/browser/ui/views/frame/browser_non_client_frame_view_unittest.cc File chrome/browser/ui/views/frame/browser_non_client_frame_view_unittest.cc (right): https://codereview.chromium.org/2775083002/diff/40001/chrome/browser/ui/views/frame/browser_non_client_frame_view_unittest.cc#newcode68 chrome/browser/ui/views/frame/browser_non_client_frame_view_unittest.cc:68: // completely outside bounds Nit: Capitals/periods
3 years, 8 months ago (2017-03-29 01:33:51 UTC) #10
Bret
https://codereview.chromium.org/2775083002/diff/40001/chrome/browser/ui/views/frame/browser_non_client_frame_view_unittest.cc File chrome/browser/ui/views/frame/browser_non_client_frame_view_unittest.cc (right): https://codereview.chromium.org/2775083002/diff/40001/chrome/browser/ui/views/frame/browser_non_client_frame_view_unittest.cc#newcode68 chrome/browser/ui/views/frame/browser_non_client_frame_view_unittest.cc:68: // completely outside bounds On 2017/03/29 01:33:51, Peter Kasting ...
3 years, 8 months ago (2017-03-29 19:12:50 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2775083002/60001
3 years, 8 months ago (2017-03-29 19:13:49 UTC) #14
commit-bot: I haz the power
3 years, 8 months ago (2017-03-29 20:13:50 UTC) #17
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/c1036c002f34914a521b631d57b8...

Powered by Google App Engine
This is Rietveld 408576698