Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 2774873002: Remove image property from ContentSuggestion (Closed)

Created:
3 years, 9 months ago by gambard
Modified:
3 years, 9 months ago
Reviewers:
stkhapugin
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, marq+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove image property from ContentSuggestion The images are fetched using a ContentSuggestionsImageFetcher. This property is not used. BUG=694159 Review-Url: https://codereview.chromium.org/2774873002 Cr-Commit-Position: refs/heads/master@{#459403} Committed: https://chromium.googlesource.com/chromium/src/+/77379e3d2fb537896faa10d251518a5c4da2269e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M ios/chrome/browser/ui/content_suggestions/content_suggestion.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ios/chrome/browser/ui/content_suggestions/content_suggestion.mm View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
gambard
PTAL.
3 years, 9 months ago (2017-03-24 13:03:48 UTC) #2
stkhapugin
lgtm
3 years, 9 months ago (2017-03-24 13:07:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2774873002/1
3 years, 9 months ago (2017-03-24 13:07:45 UTC) #5
commit-bot: I haz the power
3 years, 9 months ago (2017-03-24 13:26:53 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/77379e3d2fb537896faa10d25151...

Powered by Google App Engine
This is Rietveld 408576698