Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 2774823002: Remove FrameHost class (Closed)

Created:
3 years, 9 months ago by sashab
Modified:
3 years, 8 months ago
Reviewers:
slangley, haraken, dglazkov
CC:
aboxhall, darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-bindings_chromium.org, blink-reviews-css, blink-reviews-dom_chromium.org, blink-reviews-frames_chromium.org, blink-reviews-html_chromium.org, blink-reviews-layout_chromium.org, blink-reviews-paint_chromium.org, blink-reviews-style_chromium.org, caseq+blink_chromium.org, chromium-reviews, dcheng, devtools-reviews_chromium.org, dglazkov+blink, dmazzoni, dominicc+watchlist_chromium.org, dshwang, krit, dtapuska+blinkwatch_chromium.org, eae+blinkwatch, fmalita+watch_chromium.org, fs, gyuyoung2, jchaffraix+rendering, je_julie, kenneth.christiansen, kinuko+watch, kouhei+svg_chromium.org, kozyatinskiy+blink_chromium.org, leviw+renderwatch, lushnikov+blink_chromium.org, mlamouri+watch-blink_chromium.org, nektarios, Navid Zolghadr, pdr+svgwatchlist_chromium.org, pdr+renderingwatchlist_chromium.org, pfeldman+blink_chromium.org, rwlbuis, Stephen Chennney, sof, szager+layoutwatch_chromium.org, webcomponents-bugzilla_chromium.org, Yoav Weiss, zoltan1
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove FrameHost class BUG=688614 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2774823002 Cr-Commit-Position: refs/heads/master@{#460316} Committed: https://chromium.googlesource.com/chromium/src/+/94acef8a7271308a8cda44c1c21f91791cb6aea3

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -190 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/custom/V8CustomXPathNSResolver.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/MediaQueryEvaluator.cpp View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/resolver/StyleResolverState.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/custom/CustomElementReactionStack.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/events/EventTarget.cpp View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/BUILD.gn View 1 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/frame/BrowserControls.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/DOMVisualViewport.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/EventHandlerRegistry.h View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameConsole.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/FrameConsole.cpp View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/WebKit/Source/core/frame/FrameHost.h View 1 chunk +0 lines, -73 lines 0 comments Download
D third_party/WebKit/Source/core/frame/FrameHost.cpp View 1 chunk +0 lines, -50 lines 0 comments Download
M third_party/WebKit/Source/core/frame/LocalDOMWindow.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/frame/LocalFrame.cpp View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/LocalFrameTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/RemoteFrame.cpp View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLFormControlElementWithState.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/ImageDocument.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/input/TouchEventManager.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/MainThreadDebugger.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutFullScreen.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTestHelper.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTestHelper.cpp View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/TextAutosizer.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.cpp View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/svg/SVGLayoutSupport.cpp View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/DocumentLoader.cpp View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/EmptyClients.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/FrameFetchContext.cpp View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/FrameFetchContextTest.cpp View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/FrameLoader.cpp View 1 2 2 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/page/scrolling/TopDocumentRootScrollerController.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/page/scrolling/ViewportScrollCallback.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/SVGPaintContext.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/probe/CoreProbes.cpp View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/testing/DummyPageHolder.cpp View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/xml/XSLStyleSheetLibxslt.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/xml/XSLTProcessorLibxslt.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/ChromeClientImpl.cpp View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/ContextMenuClientImpl.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/DevToolsEmulator.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/ExternalPopupMenu.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/ExternalPopupMenuTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/InspectorEmulationAgent.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/InspectorOverlay.cpp View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/ResizeViewportAnchor.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebAXObject.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebFrameWidgetBase.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebPagePopupImpl.cpp View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebViewImpl.cpp View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/tests/BrowserControlsTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/tests/ScrollingCoordinatorTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/tests/TextFinderTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/tests/VisualViewportTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/tests/WebFrameTest.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/tests/WebInputEventConversionTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/tests/WebPluginContainerTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/tests/WebViewTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 21 (14 generated)
sashab
3 years, 9 months ago (2017-03-27 05:16:53 UTC) #7
haraken
Awesome. LGTM!
3 years, 9 months ago (2017-03-27 05:31:38 UTC) #8
dglazkov
lgtm
3 years, 9 months ago (2017-03-27 20:16:05 UTC) #10
slangley
lgtm
3 years, 9 months ago (2017-03-27 23:03:50 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2774823002/20001
3 years, 8 months ago (2017-03-29 05:05:03 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2774823002/40001
3 years, 8 months ago (2017-03-29 05:33:35 UTC) #18
commit-bot: I haz the power
3 years, 8 months ago (2017-03-29 07:25:31 UTC) #21
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/94acef8a7271308a8cda44c1c21f...

Powered by Google App Engine
This is Rietveld 408576698