Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 2774803003: Merge of "Remote fetch device status (attributes and logs) command" to M58 (Closed)

Created:
3 years, 9 months ago by Ivan Šandrk
Modified:
3 years, 9 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

Merge of "Remote fetch device status (attributes and logs) command" to M58 This CL introduces a remote command that enables device administrators to remotely fetch device status (attributes and logs). Attributes were being uploaded every 3 hours and logs every 12 hours from the device side, and there was no way to trigger a remote refresh. More context can be found by reading the design doc go/remote-audio-management The new functionality was manually tested; remote reboot command was hijacked and rewired to decode into this command and then on the server side (CPanel admin) I clicked on "REBOOT NOW" and I observed the device attributes and logs being updated. P.S. I've also fixed up some linter errors. BUG=686389 TEST=Manually tested new behaviour. Review-Url: https://codereview.chromium.org/2765463002 Cr-Commit-Position: refs/heads/master@{#459037} (cherry picked from commit 35b9ec40290254e484cc17e76ee5205b618e23c9) Review-Url: https://codereview.chromium.org/2774803003 . Cr-Commit-Position: refs/branch-heads/3029@{#407} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/63ec0fbe54d5f9ddb95a1376aec07085f7ba3078

Patch Set 1 #

Messages

Total messages: 2 (1 generated)
Ivan Šandrk
3 years, 9 months ago (2017-03-24 12:22:02 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
63ec0fbe54d5f9ddb95a1376aec07085f7ba3078.

Powered by Google App Engine
This is Rietveld 408576698