Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 2774763005: Process Expect-CT HTTP header (Closed)

Created:
3 years, 9 months ago by estark
Modified:
3 years, 7 months ago
Reviewers:
Ilya Sherman, mattm
CC:
chromium-reviews, cbentzel+watch_chromium.org, asvitkine+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Process Expect-CT HTTP header This CL processes the Expect-CT header when received on HTTP responses. TransportSecurityState parses the header and, if valid and received on a compliant connection, stores the Expect-CT state for the current host. (If valid but received on a non-compliant connection, the header information is not stored but a report is sent to alert the site owner of the misconfiguration.) A follow-up CL will check the dynamic Expect-CT state on connection setup. BUG=679012 Review-Url: https://codereview.chromium.org/2774763005 Cr-Commit-Position: refs/heads/master@{#467555} Committed: https://chromium.googlesource.com/chromium/src/+/ee03de14cb653c1e21ea4df5499a9fc183d9a921

Patch Set 1 #

Patch Set 2 : Update comment #

Patch Set 3 : rebase #

Patch Set 4 : fix unit test report syntax #

Patch Set 5 : rebase #

Total comments: 3

Patch Set 6 : fix header syntax in tests #

Total comments: 6

Patch Set 7 : mattm comments #

Patch Set 8 : fix histograms deprecated date #

Unified diffs Side-by-side diffs Delta from patch set Stats (+179 lines, -57 lines) Patch
M net/http/transport_security_state.h View 1 2 1 chunk +10 lines, -8 lines 0 comments Download
M net/http/transport_security_state.cc View 1 2 1 chunk +54 lines, -49 lines 0 comments Download
M net/http/transport_security_state_unittest.cc View 1 2 3 4 5 6 1 chunk +112 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 3 4 5 6 7 1 chunk +3 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 38 (30 generated)
estark
mattm: PTAL, thanks! (again, no time pressure) https://codereview.chromium.org/2774763005/diff/80001/net/http/transport_security_state.cc File net/http/transport_security_state.cc (left): https://codereview.chromium.org/2774763005/diff/80001/net/http/transport_security_state.cc#oldcode1384 net/http/transport_security_state.cc:1384: enum ExpectCTHeaderResult ...
3 years, 8 months ago (2017-04-21 22:09:15 UTC) #16
mattm
https://codereview.chromium.org/2774763005/diff/100001/net/http/transport_security_state_unittest.cc File net/http/transport_security_state_unittest.cc (right): https://codereview.chromium.org/2774763005/diff/100001/net/http/transport_security_state_unittest.cc#newcode2681 net/http/transport_security_state_unittest.cc:2681: base::Time now; not initialized https://codereview.chromium.org/2774763005/diff/100001/net/http/transport_security_state_unittest.cc#newcode2682 net/http/transport_security_state_unittest.cc:2682: TransportSecurityState state; Should ...
3 years, 7 months ago (2017-04-25 22:08:42 UTC) #23
estark
https://codereview.chromium.org/2774763005/diff/100001/net/http/transport_security_state_unittest.cc File net/http/transport_security_state_unittest.cc (right): https://codereview.chromium.org/2774763005/diff/100001/net/http/transport_security_state_unittest.cc#newcode2681 net/http/transport_security_state_unittest.cc:2681: base::Time now; On 2017/04/25 22:08:42, mattm wrote: > not ...
3 years, 7 months ago (2017-04-26 00:55:07 UTC) #25
mattm
lgtm
3 years, 7 months ago (2017-04-26 19:46:17 UTC) #29
estark
isherman, can you please review histograms.xml?
3 years, 7 months ago (2017-04-26 19:50:25 UTC) #31
Ilya Sherman
histograms.xml lgtm, thanks
3 years, 7 months ago (2017-04-26 23:21:31 UTC) #32
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2774763005/140001
3 years, 7 months ago (2017-04-27 00:26:29 UTC) #35
commit-bot: I haz the power
3 years, 7 months ago (2017-04-27 02:36:17 UTC) #38
Message was sent while issue was closed.
Committed patchset #8 (id:140001) as
https://chromium.googlesource.com/chromium/src/+/ee03de14cb653c1e21ea4df5499a...

Powered by Google App Engine
This is Rietveld 408576698