Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(574)

Issue 2774763004: Adding deadbeef@ as owner of webrtc/media/. (Closed)

Created:
3 years, 9 months ago by Taylor Brandstetter
Modified:
3 years, 9 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Adding deadbeef@ as owner of webrtc/media/. BUG=None NOTRY=True Review-Url: https://codereview.webrtc.org/2774763004 Cr-Commit-Position: refs/heads/master@{#17378} Committed: https://chromium.googlesource.com/external/webrtc/+/2ca33ee3d5fad2e8980b718b6a0c862d15d88322

Patch Set 1 #

Patch Set 2 : Adding back pbos@ (he's still willing to do code reviews) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M webrtc/media/OWNERS View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
Taylor Brandstetter
Hi all; do you think it would be a good idea to have me as ...
3 years, 9 months ago (2017-03-24 16:33:57 UTC) #4
pbos-webrtc
Yes, A++/10. Would suggest again. You've handled code changes in webrtc/media/ very responsibly before, have ...
3 years, 9 months ago (2017-03-24 16:36:35 UTC) #5
pbos-webrtc
On 2017/03/24 16:36:35, pbos-webrtc wrote: > Yes, A++/10. Would suggest again. > > You've handled ...
3 years, 9 months ago (2017-03-24 16:37:22 UTC) #6
perkj_webrtc
lgtm
3 years, 9 months ago (2017-03-24 16:38:21 UTC) #7
the sun
lgtm
3 years, 9 months ago (2017-03-24 20:36:57 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2774763004/20001
3 years, 9 months ago (2017-03-24 21:22:43 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/external/webrtc/+/2ca33ee3d5fad2e8980b718b6a0c862d15d88322
3 years, 9 months ago (2017-03-24 21:25:58 UTC) #13
pthatcher1
lgtm
3 years, 9 months ago (2017-03-25 05:14:25 UTC) #14
mflodman
3 years, 9 months ago (2017-03-26 09:01:23 UTC) #15
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698