Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1342)

Issue 2774763002: Kick incognito tabs from CCTs to tabbed mode. (Closed)

Created:
3 years, 9 months ago by Ted C
Modified:
3 years, 9 months ago
Reviewers:
Theresa
CC:
chromium-reviews, lizeb+watch-custom-tabs_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Kick incognito tabs from CCTs to tabbed mode. BUG=697849 Review-Url: https://codereview.chromium.org/2774763002 Cr-Commit-Position: refs/heads/master@{#459560} Committed: https://chromium.googlesource.com/chromium/src/+/161a32635f89a1f6bfde9e8f5836d747529a0d56

Patch Set 1 #

Total comments: 2

Patch Set 2 : Update method name #

Patch Set 3 : Fix test #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+124 lines, -3 lines) Patch
M chrome/android/BUILD.gn View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java View 1 2 3 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabDelegateFactory.java View 3 chunks +38 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/multiwindow/MultiWindowUtils.java View 3 chunks +5 lines, -3 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTest.java View 1 2 4 chunks +73 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (11 generated)
Ted C
PTAL
3 years, 9 months ago (2017-03-23 19:04:19 UTC) #2
Theresa
lgtm https://codereview.chromium.org/2774763002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java File chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java (right): https://codereview.chromium.org/2774763002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java#newcode1432 chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java:1432: public boolean isTabModelsInitialized() { nit: areTabModelsInitialized
3 years, 9 months ago (2017-03-23 21:09:09 UTC) #3
Ted C
https://codereview.chromium.org/2774763002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java File chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java (right): https://codereview.chromium.org/2774763002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java#newcode1432 chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java:1432: public boolean isTabModelsInitialized() { On 2017/03/23 21:09:09, Theresa wrote: ...
3 years, 9 months ago (2017-03-23 22:06:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2774763002/20001
3 years, 9 months ago (2017-03-23 22:06:56 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/256823)
3 years, 9 months ago (2017-03-24 00:24:01 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2774763002/40001
3 years, 9 months ago (2017-03-24 15:54:41 UTC) #12
commit-bot: I haz the power
Failed to apply patch for chrome/android/BUILD.gn: While running git apply --index -p1; error: patch failed: ...
3 years, 9 months ago (2017-03-24 17:34:18 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2774763002/60001
3 years, 9 months ago (2017-03-24 18:12:01 UTC) #17
commit-bot: I haz the power
3 years, 9 months ago (2017-03-24 21:36:53 UTC) #20
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/161a32635f89a1f6bfde9e8f5836...

Powered by Google App Engine
This is Rietveld 408576698