Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 2774723004: Update :in-range/:out-of-range when steppable min/max/value changes. (Closed)

Created:
3 years, 9 months ago by rune
Modified:
3 years, 9 months ago
Reviewers:
tkent
CC:
chromium-reviews, blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Update :in-range/:out-of-range when steppable min/max/value changes. We called pseudoStateChanged in a lot of cases where it wasn't necessary. It should suffice to call it for the mentioned pseudo classes when the min and max attributes changes, or the value is changed, either as an attribute or as a result of user input. This should fix the performance regressions in issue 704775. R=tkent@chromium.org BUG=704775 Review-Url: https://codereview.chromium.org/2774723004 Cr-Commit-Position: refs/heads/master@{#459733} Committed: https://chromium.googlesource.com/chromium/src/+/b2cdcbfc13078c618e722c988e5afc0a5d435e74

Patch Set 1 #

Patch Set 2 : Moved code to InputType class. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -7 lines) Patch
M third_party/WebKit/Source/core/html/HTMLFormControlElement.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLInputElement.cpp View 1 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/html/forms/InputType.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/forms/InputType.cpp View 1 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
rune
ptal I was unsure whether the inRangeChanged() code should be on the HTMLInputElement, the InputView, ...
3 years, 9 months ago (2017-03-24 14:52:50 UTC) #3
tkent
> I was unsure whether the inRangeChanged() code should be on the HTMLInputElement, the InputView, ...
3 years, 9 months ago (2017-03-26 23:38:19 UTC) #6
rune
On 2017/03/26 23:38:19, tkent wrote: > > I was unsure whether the inRangeChanged() code should ...
3 years, 9 months ago (2017-03-27 07:56:03 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2774723004/20001
3 years, 9 months ago (2017-03-27 07:56:24 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-03-27 09:38:46 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/b2cdcbfc13078c618e722c988e5a...

Powered by Google App Engine
This is Rietveld 408576698