Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1127)

Issue 2774683002: Re-land: Add a window property to associate RWHVA with its child AX tree ID (Closed)

Created:
3 years, 9 months ago by dmazzoni
Modified:
3 years, 9 months ago
Reviewers:
jam, sky
CC:
chromium-reviews, creis+watch_chromium.org, yusukes+watch_chromium.org, tfarina, aboxhall+watch_chromium.org, shuchen+watch_chromium.org, nasko+codewatch_chromium.org, jam, nektar+watch_chromium.org, yuzo+watch_chromium.org, jbauman+watch_chromium.org, nona+watch_chromium.org, je_julie, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, piman+watch_chromium.org, kalyank, danakj+watch_chromium.org, James Su
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-land: Add a window property to associate RWHVA with its child AX tree ID Originally landed: https://codereview.chromium.org/2742533003/ Reverted: https://codereview.chromium.org/2751503002/ Only change: makes kNoAXTreeID into a constexpr to avoid a static initializer BUG=699617 TBR=sky@chromium.org,jam@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2774683002 Cr-Commit-Position: refs/heads/master@{#459161} Committed: https://chromium.googlesource.com/chromium/src/+/4768bdb54f0b4c308d325c4ff0563a40744fc156

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -5 lines) Patch
M content/browser/frame_host/render_frame_host_impl.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_base.h View 2 chunks +2 lines, -1 line 0 comments Download
M ui/accessibility/BUILD.gn View 1 chunk +9 lines, -0 lines 0 comments Download
M ui/accessibility/DEPS View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/accessibility/ax_tree_id_registry.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/accessibility/ax_tree_id_registry.cc View 1 chunk +0 lines, -3 lines 0 comments Download
A ui/accessibility/platform/aura_window_properties.h View 1 chunk +19 lines, -0 lines 0 comments Download
A ui/accessibility/platform/aura_window_properties.cc View 1 chunk +15 lines, -0 lines 0 comments Download
M ui/views/accessibility/ax_window_obj_wrapper.cc View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
dmazzoni
3 years, 9 months ago (2017-03-23 16:22:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2774683002/1
3 years, 9 months ago (2017-03-23 16:22:57 UTC) #4
sky
LGTM - next time around please upload the reverted patch as patchset 1 and patchset ...
3 years, 9 months ago (2017-03-23 16:33:58 UTC) #5
commit-bot: I haz the power
3 years, 9 months ago (2017-03-23 18:49:00 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4768bdb54f0b4c308d325c4ff056...

Powered by Google App Engine
This is Rietveld 408576698