Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 2774663003: Simplify the SelectorQuery constructor and reuse CSSSelectorList::length(). (Closed)

Created:
3 years, 9 months ago by esprehn
Modified:
3 years, 9 months ago
Reviewers:
sashab, rune
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Simplify the SelectorQuery constructor and reuse CSSSelectorList::length(). Instead of reimplementing length(), lets just give it a name that makes it clear it's actually doing work and isn't free so folks don't use it in for loops. BUG=703900 Review-Url: https://codereview.chromium.org/2774663003 Cr-Commit-Position: refs/heads/master@{#459279} Committed: https://chromium.googlesource.com/chromium/src/+/eec8e66dfa3536d3ab04a497434490ace4ae75cf

Patch Set 1 #

Patch Set 2 : pseudos can be empty.. #

Patch Set 3 : woops #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -16 lines) Patch
M third_party/WebKit/Source/core/css/CSSSelectorList.h View 1 chunk +4 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/CSSSelectorList.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/SelectorQuery.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/SelectorQuery.cpp View 1 2 2 chunks +6 lines, -13 lines 0 comments Download

Messages

Total messages: 18 (14 generated)
esprehn
3 years, 9 months ago (2017-03-23 20:10:39 UTC) #4
rune
lgtm
3 years, 9 months ago (2017-03-23 23:02:58 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2774663003/40001
3 years, 9 months ago (2017-03-23 23:20:00 UTC) #15
commit-bot: I haz the power
3 years, 9 months ago (2017-03-23 23:33:59 UTC) #18
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/eec8e66dfa3536d3ab04a4974344...

Powered by Google App Engine
This is Rietveld 408576698