Refactor Password Manager to use base::EraseIf

Refactor Password Manager to use base::EraseIf

This change replaces the erase-remove idiom by calls to base::EraseIf
in the Password Manager code where appropriate.

BUG=705433
R=vasilii@chromium.org

Review-Url: https://codereview.chromium.org/2774653006
Cr-Commit-Position: refs/heads/master@{#459761}
Committed: https://chromium.googlesource.com/chromium/src/+/0606479c7c2a17b6d20a61a3034eddd13838e722

[jdoerrie, 2017-03-24 16:57:07]

The CQ bit was checked by jdoerrie@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-24 16:57:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jdoerrie, 2017-03-24 16:58:28]

Hi Vasilii, please review :)

[commit-bot: I haz the power, 2017-03-24 17:44:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-24 17:44:05]

Dry run: This issue passed the CQ dry run.

[vabr (Chromium), 2017-03-25 08:14:50]

vabr@chromium.org changed reviewers:
+ vabr@chromium.org

[vabr (Chromium), 2017-03-25 08:14:51]

LGTM, thanks for the clean-up.

Optionally, you can create a bug for this, assign to yourself and associate it
in the CL description. In performance review time, for me it is easier to list
and find my past achievements if they are tracked in this way. Your habits may
vary, so just checking that you considered it.

Cheers,
Vaclav

[vasilii, 2017-03-27 07:42:30]

lgtm

[jdoerrie, 2017-03-27 08:16:57]

Description was changed from

==========
Refactor Password Manager to use base::EraseIf

This change replaces the erase-remove idiom by calls to base::EraseIf
in the Password Manager code where appropriate.

BUG=NONE
R=vasilii@chromium.org
==========

to

==========
Refactor Password Manager to use base::EraseIf

This change replaces the erase-remove idiom by calls to base::EraseIf
in the Password Manager code where appropriate.

BUG=705433
R=vasilii@chromium.org
==========

[jdoerrie, 2017-03-27 08:18:14]

Thanks for the LGTMs and the reminder to create an appropriate bug. I initially
thought it wasn't necessary for this rather small CL but your point regarding
perf makes sense, thanks :)

[jdoerrie, 2017-03-27 08:18:20]

The CQ bit was checked by jdoerrie@chromium.org

[commit-bot: I haz the power, 2017-03-27 08:18:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-27 09:26:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-27 09:26:04]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[jdoerrie, 2017-03-27 10:59:14]

The CQ bit was checked by jdoerrie@chromium.org

[commit-bot: I haz the power, 2017-03-27 10:59:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-27 12:43:14]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1490612354414650, "parent_rev":
"ad63c7ef733f2301baf0320d796ca1293a518e72", "commit_rev":
"0606479c7c2a17b6d20a61a3034eddd13838e722"}

[commit-bot: I haz the power, 2017-03-27 12:43:57]

Description was changed from

==========
Refactor Password Manager to use base::EraseIf

This change replaces the erase-remove idiom by calls to base::EraseIf
in the Password Manager code where appropriate.

BUG=705433
R=vasilii@chromium.org
==========

to

==========
Refactor Password Manager to use base::EraseIf

This change replaces the erase-remove idiom by calls to base::EraseIf
in the Password Manager code where appropriate.

BUG=705433
R=vasilii@chromium.org

Review-Url: https://codereview.chromium.org/2774653006
Cr-Commit-Position: refs/heads/master@{#459761}
Committed:
https://chromium.googlesource.com/chromium/src/+/0606479c7c2a17b6d20a61a3034e...
==========

[commit-bot: I haz the power, 2017-03-27 12:43:58]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0606479c7c2a17b6d20a61a3034e...