Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2774653003:
Initialize COM STA in the service process. (Closed)
DescriptionInitialize COM STA in the service process.
BUG=704754
Review-Url: https://codereview.chromium.org/2774653003
Cr-Commit-Position: refs/heads/master@{#459353}
Committed: https://chromium.googlesource.com/chromium/src/+/d36381e3b65747fc7ea9df344129fa7ced3a0afe
Patch Set 1 #
Total comments: 3
Patch Set 2 : INIT_COM_STA for reals #Messages
Total messages: 17 (12 generated)
The CQ bit was checked by thestig@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
robliao@chromium.org changed reviewers: + robliao@chromium.org
https://codereview.chromium.org/2774653003/diff/1/chrome/service/service_proc... File chrome/service/service_process.cc (right): https://codereview.chromium.org/2774653003/diff/1/chrome/service/service_proc... chrome/service/service_process.cc:171: kMaxTaskSchedulerThreads, base::TimeDelta::FromSeconds(30)); Given that you need COM to be initialized, you'll need to specify SchedulerBackwardCompatibility::INIT_COM_STA.
The CQ bit was checked by thestig@chromium.org to run a CQ dry run
https://codereview.chromium.org/2774653003/diff/1/chrome/service/service_proc... File chrome/service/service_process.cc (right): https://codereview.chromium.org/2774653003/diff/1/chrome/service/service_proc... chrome/service/service_process.cc:171: kMaxTaskSchedulerThreads, base::TimeDelta::FromSeconds(30)); On 2017/03/24 00:40:17, robliao wrote: > Given that you need COM to be initialized, you'll need to specify > SchedulerBackwardCompatibility::INIT_COM_STA. Doh. That's rather embarassing.
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm. Adding some from our team. FYI, we have an interesting case where we need the simple scheduler + COM initialization. This will be made better with COM Task Runners, in progress right now. https://codereview.chromium.org/2774653003/diff/1/chrome/service/service_proc... File chrome/service/service_process.cc (right): https://codereview.chromium.org/2774653003/diff/1/chrome/service/service_proc... chrome/service/service_process.cc:171: kMaxTaskSchedulerThreads, base::TimeDelta::FromSeconds(30)); On 2017/03/24 01:15:34, Lei Zhang wrote: > On 2017/03/24 00:40:17, robliao wrote: > > Given that you need COM to be initialized, you'll need to specify > > SchedulerBackwardCompatibility::INIT_COM_STA. > > Doh. That's rather embarassing. Happens to all of us :-)
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by thestig@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490325682747690,
"parent_rev": "115663853cd6d59c87f6b605381d52498c179bfb", "commit_rev":
"d36381e3b65747fc7ea9df344129fa7ced3a0afe"}
Message was sent while issue was closed.
Description was changed from ========== Initialize COM STA in the service process. BUG=704754 ========== to ========== Initialize COM STA in the service process. BUG=704754 Review-Url: https://codereview.chromium.org/2774653003 Cr-Commit-Position: refs/heads/master@{#459353} Committed: https://chromium.googlesource.com/chromium/src/+/d36381e3b65747fc7ea9df344129... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/d36381e3b65747fc7ea9df344129... |
