Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6267)

Unified Diff: components/metrics/metrics_reporting_service.cc

Issue 2774503002: Track network stack error codes from UMA and UKM (Closed)
Patch Set: Diffbase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/metrics/metrics_reporting_service.cc
diff --git a/components/metrics/metrics_reporting_service.cc b/components/metrics/metrics_reporting_service.cc
index 116a67f190a4ebc1d04146386e750c3447e633eb..26db01cc50527f7499d9659dfc75eed42d5f1325 100644
--- a/components/metrics/metrics_reporting_service.cc
+++ b/components/metrics/metrics_reporting_service.cc
@@ -96,6 +96,10 @@ void MetricsReportingService::LogResponseCode(int response_code) {
NUM_RESPONSE_STATUSES);
}
+void MetricsReportingService::LogErrorCode(int error_code) {
+ UMA_HISTOGRAM_SPARSE_SLOWLY("UMA.FailedUploadErrorCode", -error_code);
Alexei Svitkine (slow) 2017/03/23 15:23:42 I think error and response code should be logged i
Steven Holte 2017/03/23 20:38:07 Done.
+}
+
void MetricsReportingService::LogSuccess(size_t log_size) {
UMA_HISTOGRAM_COUNTS_10000("UMA.LogSize.OnSuccess", log_size / 1024);
}

Powered by Google App Engine
This is Rietveld 408576698