Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1525)

Unified Diff: components/metrics/reporting_service.h

Issue 2774503002: Track network stack error codes from UMA and UKM (Closed)
Patch Set: Rebase on Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/metrics/reporting_service.h
diff --git a/components/metrics/reporting_service.h b/components/metrics/reporting_service.h
index 03bf7a90c71787176adc92c889febab23c0a31fb..017bcc2a5774eaeb7a38773ab2f9e13fbab28269 100644
--- a/components/metrics/reporting_service.h
+++ b/components/metrics/reporting_service.h
@@ -89,7 +89,7 @@ class ReportingService {
// Methods for recording data to histograms.
virtual void LogActualUploadInterval(base::TimeDelta interval) {}
virtual void LogCellularConstraint(bool upload_canceled) {}
- virtual void LogResponseCode(int response_code) {}
+ virtual void LogResponseOrErrorCode(int response_code, int error_code) {}
virtual void LogSuccess(size_t log_size) {}
virtual void LogLargeRejection(size_t log_size) {}
@@ -101,7 +101,7 @@ class ReportingService {
void SendStagedLog();
// Called after transmission completes (either successfully or with failure).
- void OnLogUploadComplete(int response_code);
+ void OnLogUploadComplete(int response_code, int error_code);
// Used to interact with the embedder. Weak pointer; must outlive |this|
// instance.
« no previous file with comments | « components/metrics/net/net_metrics_log_uploader_unittest.cc ('k') | components/metrics/reporting_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698