Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Unified Diff: components/metrics/net/net_metrics_log_uploader.cc

Issue 2774503002: Track network stack error codes from UMA and UKM (Closed)
Patch Set: Rebase on Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/metrics/net/net_metrics_log_uploader.cc
diff --git a/components/metrics/net/net_metrics_log_uploader.cc b/components/metrics/net/net_metrics_log_uploader.cc
index 05d1f5c9894db453e76d3addb33fe8d7540d8fbd..e7dac872d37d6d210588f9e40205ee2d998d888c 100644
--- a/components/metrics/net/net_metrics_log_uploader.cc
+++ b/components/metrics/net/net_metrics_log_uploader.cc
@@ -102,7 +102,7 @@ NetMetricsLogUploader::NetMetricsLogUploader(
base::StringPiece server_url,
base::StringPiece mime_type,
MetricsLogUploader::MetricServiceType service_type,
- const base::Callback<void(int)>& on_upload_complete)
+ const MetricsLogUploader::UploadCallback& on_upload_complete)
: request_context_getter_(request_context_getter),
server_url_(server_url),
mime_type_(mime_type.data(), mime_type.size()),
@@ -155,8 +155,13 @@ void NetMetricsLogUploader::OnURLFetchComplete(const net::URLFetcher* source) {
int response_code = source->GetResponseCode();
if (response_code == net::URLFetcher::RESPONSE_CODE_INVALID)
response_code = -1;
+ int error_code = 0;
+ const net::URLRequestStatus& request_status = source->GetStatus();
+ if (request_status.status() != net::URLRequestStatus::SUCCESS) {
+ error_code = request_status.error();
+ }
current_fetch_.reset();
- on_upload_complete_.Run(response_code);
+ on_upload_complete_.Run(response_code, error_code);
}
} // namespace metrics
« no previous file with comments | « components/metrics/net/net_metrics_log_uploader.h ('k') | components/metrics/net/net_metrics_log_uploader_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698