Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issue 2774493002: [inspector] run more tests with InspectorTest.setupInjectedScriptEnvironment (Closed)

Created:
3 years, 9 months ago by kozy
Modified:
3 years, 9 months ago
Reviewers:
dgozman
CC:
v8-reviews_googlegroups.com, devtools-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[inspector] run more tests with InspectorTest.setupInjectedScriptEnvironment + bonus: new version of get-properties.js test - good illustration of out progress in tests. BUG=none R=dgozman@chromium.org Review-Url: https://codereview.chromium.org/2774493002 Cr-Commit-Position: refs/heads/master@{#44121} Committed: https://chromium.googlesource.com/v8/v8/+/c72c90bc7422e6a594604f00deb0d6c5d562e478

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -234 lines) Patch
M test/inspector/runtime/get-properties.js View 2 chunks +64 lines, -227 lines 0 comments Download
M test/inspector/runtime/get-properties-expected.txt View 3 chunks +15 lines, -7 lines 0 comments Download
M test/inspector/runtime/get-properties-preview.js View 1 1 chunk +2 lines, -0 lines 0 comments Download
M test/inspector/runtime/length-or-size-description.js View 1 1 chunk +2 lines, -0 lines 0 comments Download
M test/inspector/runtime/set-or-map-entries.js View 1 1 chunk +2 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 11 (7 generated)
kozy
Dmitry, please take a look.
3 years, 9 months ago (2017-03-23 00:00:33 UTC) #1
dgozman
lgtm
3 years, 9 months ago (2017-03-23 21:47:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2774493002/20001
3 years, 9 months ago (2017-03-24 18:20:12 UTC) #8
commit-bot: I haz the power
3 years, 9 months ago (2017-03-24 18:43:29 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/c72c90bc7422e6a594604f00deb0d6c5d56...

Powered by Google App Engine
This is Rietveld 408576698