Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 2774473003: Simplify pre+post GC ThreadState steps. (Closed)

Created:
3 years, 9 months ago by sof
Modified:
3 years, 9 months ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews, oilpan-reviews, Mads Ager (chromium), blink-reviews, kinuko+watch, kouhei+heap_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Simplify pre+post GC ThreadState steps. No need to involve the ThreadHeap for these, as they're entirely handled by the ThreadState now. R= BUG=671856 Review-Url: https://codereview.chromium.org/2774473003 Cr-Commit-Position: refs/heads/master@{#459373} Committed: https://chromium.googlesource.com/chromium/src/+/a6f6765d9e37b6f1bb499191bf07b8c24bd04041

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -24 lines) Patch
M third_party/WebKit/Source/platform/heap/Heap.h View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/Heap.cpp View 1 chunk +0 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/HeapTest.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/ThreadState.cpp View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
sof
please take a look.
3 years, 9 months ago (2017-03-23 19:01:37 UTC) #4
haraken
LGTM
3 years, 9 months ago (2017-03-23 23:40:05 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2774473003/1
3 years, 9 months ago (2017-03-24 04:48:11 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-24 06:30:48 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a6f6765d9e37b6f1bb499191bf07...

Powered by Google App Engine
This is Rietveld 408576698