Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(595)

Issue 2774433003: Add new entry in VideoPersistenceEndReason. (Closed)

Created:
3 years, 9 months ago by mlamouri (slow - plz ping)
Modified:
3 years, 9 months ago
Reviewers:
Ilya Sherman
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

Add new entry in VideoPersistenceEndReason. BUG=703742 R=isherman@chromium.org Review-Url: https://codereview.chromium.org/2769723002 Cr-Commit-Position: refs/heads/master@{#458898} (cherry picked from commit fa9ba6d9ad044d07901d53ac5ccaeea4bae10b45) Review-Url: https://codereview.chromium.org/2774433003 . Cr-Commit-Position: refs/branch-heads/3029@{#385} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/7a1436f14727c7e141468579e879b3a2c96038f7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M tools/metrics/histograms/histograms.xml View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
mlamouri (slow - plz ping)
Committed patchset #1 (id:1) manually as 7a1436f14727c7e141468579e879b3a2c96038f7.
3 years, 9 months ago (2017-03-23 14:18:01 UTC) #2
Ilya Sherman
FYI, there's no need to merge changes to any of the XML files to branches ...
3 years, 9 months ago (2017-03-23 19:37:42 UTC) #3
mlamouri (slow - plz ping)
On 2017/03/23 at 19:37:42, isherman wrote: > FYI, there's no need to merge changes to ...
3 years, 9 months ago (2017-03-23 19:44:35 UTC) #4
Ilya Sherman
3 years, 9 months ago (2017-03-23 19:52:44 UTC) #5
Message was sent while issue was closed.
On 2017/03/23 19:44:35, mlamouri wrote:
> On 2017/03/23 at 19:37:42, isherman wrote:
> > FYI, there's no need to merge changes to any of the XML files to branches --
> we always read them at head.
> 
> Thanks for ping :) I know we read histograms.xml from trunk but because some
CLs
> change histograms.xml, to avoid random rebase, I prefer merge these two. I
> assume it is not required to merge histograms.xml but it is okay to do so. Let
> me know if it's preferred not to merge CLs like these.

Okay.  It's fine either way =)

Powered by Google App Engine
This is Rietveld 408576698