Move getCached/getUncachedPseudoStyle to Element.

Move getCached/getUncachedPseudoStyle to Element.

This CL moves the handling of pseudo-element styles to Element, as a
pre-requisite for display: contents pseudo-elements support.

I think this may have visible effects on first-line/first-letter (where we
specifiy parentStyle explicitly).

If it does, we need to special-case that in LayoutObject. If not, we may as
well remove that argument altogether.

BUG=657748
Review-Url: https://codereview.chromium.org/2774383002
Cr-Commit-Position: refs/heads/master@{#460146}
Committed: https://chromium.googlesource.com/chromium/src/+/3e92f75741339da0c094fd863bb4a79575a74792

[emilio, 2017-03-27 16:30:05]

The CQ bit was checked by ecobos@igalia.com to run a CQ dry run

[commit-bot: I haz the power, 2017-03-27 16:30:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-27 17:46:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-27 17:46:00]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[emilio, 2017-03-27 19:04:48]

The CQ bit was checked by ecobos@igalia.com to run a CQ dry run

[commit-bot: I haz the power, 2017-03-27 19:05:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-27 19:54:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-27 19:54:19]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[emilio, 2017-03-27 22:40:54]

The CQ bit was checked by ecobos@igalia.com to run a CQ dry run

[commit-bot: I haz the power, 2017-03-27 22:41:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-28 00:34:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-28 00:34:30]

Dry run: Try jobs failed on following builders:
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[emilio, 2017-03-28 07:14:48]

The CQ bit was checked by ecobos@igalia.com to run a CQ dry run

[commit-bot: I haz the power, 2017-03-28 07:14:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-28 07:48:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-28 07:48:29]

Dry run: This issue passed the CQ dry run.

[emilio, 2017-03-28 08:23:26]

ecobos@igalia.com changed reviewers:
+ rune@opera.com

[emilio, 2017-03-28 08:23:26]

Hi rune,

Could you take a look at this patch? This is also mostly split off the display:
contents pseudo CL, but with all the logic moved to Element instead of just
::before and ::after.

Thanks!

[rune, 2017-03-28 13:07:03]

https://codereview.chromium.org/2774383002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/dom/Element.cpp (right):

https://codereview.chromium.org/2774383002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/Element.cpp:3383: const_cast<Element*>(this),
request, style,
Why not make the methods non-const instead?

[emilio, 2017-03-28 13:42:47]

On 2017/03/28 13:07:03, rune wrote:
>
https://codereview.chromium.org/2774383002/diff/40001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/core/dom/Element.cpp (right):
> 
>
https://codereview.chromium.org/2774383002/diff/40001/third_party/WebKit/Sour...
> third_party/WebKit/Source/core/dom/Element.cpp:3383:
const_cast<Element*>(this),
> request, style,
> Why not make the methods non-const instead?

Just for API consistency with the LayoutObject methods. I guess I can do that
though.

[rune, 2017-03-28 13:55:30]

On 2017/03/28 13:42:47, emilio wrote:
> On 2017/03/28 13:07:03, rune wrote:

> > Why not make the methods non-const instead?
> 
> Just for API consistency with the LayoutObject methods. I guess I can do that
> though.

I don't see a point in trying to hide the fact that it has side-effects, and
also, the methods are in fact invoked on non-const Elements afaict.

[emilio, 2017-03-28 14:38:17]

On 2017/03/28 13:55:30, rune wrote:
> On 2017/03/28 13:42:47, emilio wrote:
> > On 2017/03/28 13:07:03, rune wrote:
> 
> > > Why not make the methods non-const instead?
> > 
> > Just for API consistency with the LayoutObject methods. I guess I can do
that
> > though.
> 
> I don't see a point in trying to hide the fact that it has side-effects, and
> also, the methods are in fact invoked on non-const Elements afaict.

Done, then.

[rune, 2017-03-28 14:41:53]

lgtm

[emilio, 2017-03-28 14:53:47]

The CQ bit was checked by ecobos@igalia.com

[commit-bot: I haz the power, 2017-03-28 14:54:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-28 17:15:18]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1490712827380550,
"parent_rev": "93efceba4cc433d79d7daeb3fd8d03e1833b2115", "commit_rev":
"3e92f75741339da0c094fd863bb4a79575a74792"}

[commit-bot: I haz the power, 2017-03-28 17:16:10]

Description was changed from

==========
Move getCached/getUncachedPseudoStyle to Element.

This CL moves the handling of pseudo-element styles to Element, as a
pre-requisite for display: contents pseudo-elements support.

I think this may have visible effects on first-line/first-letter (where we
specifiy parentStyle explicitly).

If it does, we need to special-case that in LayoutObject. If not, we may as
well remove that argument altogether.

BUG=657748
==========

to

==========
Move getCached/getUncachedPseudoStyle to Element.

This CL moves the handling of pseudo-element styles to Element, as a
pre-requisite for display: contents pseudo-elements support.

I think this may have visible effects on first-line/first-letter (where we
specifiy parentStyle explicitly).

If it does, we need to special-case that in LayoutObject. If not, we may as
well remove that argument altogether.

BUG=657748

Review-Url: https://codereview.chromium.org/2774383002
Cr-Commit-Position: refs/heads/master@{#460146}
Committed:
https://chromium.googlesource.com/chromium/src/+/3e92f75741339da0c094fd863bb4...
==========

[commit-bot: I haz the power, 2017-03-28 17:16:11]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/3e92f75741339da0c094fd863bb4...