Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(820)

Unified Diff: content/browser/frame_sink_provider_impl.h

Issue 2774373002: Use MojoCompositorFrameSink in RendererCompositorFrameSink (Closed)
Patch Set: Fixed mac Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_sink_provider_impl.h
diff --git a/content/browser/frame_sink_provider_impl.h b/content/browser/frame_sink_provider_impl.h
new file mode 100644
index 0000000000000000000000000000000000000000..2865eca6116af828f02a649a382f805a011606f5
--- /dev/null
+++ b/content/browser/frame_sink_provider_impl.h
@@ -0,0 +1,33 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CONTENT_BROWSER_RENDER_WIDGET_COMPOSITOR_FRAME_SINK_PROVIDER_H_
+#define CONTENT_BROWSER_RENDER_WIDGET_COMPOSITOR_FRAME_SINK_PROVIDER_H_
+
+#include "content/common/frame_sink_provider.mojom.h"
+#include "mojo/public/cpp/bindings/binding.h"
+
+namespace content {
+
+class FrameSinkProviderImpl : public mojom::FrameSinkProvider {
Fady Samuel 2017/04/10 02:28:38 Class level description of what this does.
Saman Sami 2017/04/10 02:37:47 Yes absolutely.
Saman Sami 2017/04/10 15:05:51 Done.
+ public:
+ FrameSinkProviderImpl(int32_t process_id);
Fady Samuel 2017/04/10 02:28:38 nit: explicit
Saman Sami 2017/04/10 02:37:47 Acknowledged.
Saman Sami 2017/04/10 15:05:51 Done.
+ ~FrameSinkProviderImpl() override;
+
+ void Bind(mojom::FrameSinkProviderRequest request);
+
+ // mojom::FrameSinkProvider implementation.
+ void CreateForWidget(
+ int32_t widget_id,
Fady Samuel 2017/04/10 02:28:38 This is actually the routing_id, right?
Saman Sami 2017/04/10 02:37:48 Yes but see my comment in cc file please.
+ cc::mojom::MojoCompositorFrameSinkRequest request,
+ cc::mojom::MojoCompositorFrameSinkClientPtr client) override;
+
+ private:
+ int32_t process_id_;
Fady Samuel 2017/04/10 02:28:38 nit: const int32_t?
Saman Sami 2017/04/10 02:37:47 Acknowledged.
Saman Sami 2017/04/10 15:05:51 Done.
+ mojo::Binding<mojom::FrameSinkProvider> binding_;
Fady Samuel 2017/04/10 02:28:38 DISALLOW_COPY_AND_ASSIGN...
Saman Sami 2017/04/10 02:37:47 Acknowledged.
Saman Sami 2017/04/10 15:05:51 Done.
+};
+
+} // namespace content
+
+#endif // CONTENT_BROWSER_RENDER_WIDGET_COMPOSITOR_FRAME_SINK_PROVIDER_H_

Powered by Google App Engine
This is Rietveld 408576698