Chromium Code Reviews| OLD | NEW |
|---|---|
| (Empty) | |
| 1 // Copyright 2017 The Chromium Authors. All rights reserved. | |
| 2 // Use of this source code is governed by a BSD-style license that can be | |
| 3 // found in the LICENSE file. | |
| 4 | |
| 5 #ifndef CONTENT_BROWSER_RENDER_WIDGET_COMPOSITOR_FRAME_SINK_PROVIDER_H_ | |
| 6 #define CONTENT_BROWSER_RENDER_WIDGET_COMPOSITOR_FRAME_SINK_PROVIDER_H_ | |
| 7 | |
| 8 #include "content/common/frame_sink_provider.mojom.h" | |
| 9 #include "mojo/public/cpp/bindings/binding.h" | |
| 10 | |
| 11 namespace content { | |
| 12 | |
| 13 class FrameSinkProviderImpl : public mojom::FrameSinkProvider { | |
|
Fady Samuel
2017/04/10 02:28:38
Class level description of what this does.
Saman Sami
2017/04/10 02:37:47
Yes absolutely.
Saman Sami
2017/04/10 15:05:51
Done.
| |
| 14 public: | |
| 15 FrameSinkProviderImpl(int32_t process_id); | |
|
Fady Samuel
2017/04/10 02:28:38
nit: explicit
Saman Sami
2017/04/10 02:37:47
Acknowledged.
Saman Sami
2017/04/10 15:05:51
Done.
| |
| 16 ~FrameSinkProviderImpl() override; | |
| 17 | |
| 18 void Bind(mojom::FrameSinkProviderRequest request); | |
| 19 | |
| 20 // mojom::FrameSinkProvider implementation. | |
| 21 void CreateForWidget( | |
| 22 int32_t widget_id, | |
|
Fady Samuel
2017/04/10 02:28:38
This is actually the routing_id, right?
Saman Sami
2017/04/10 02:37:48
Yes but see my comment in cc file please.
| |
| 23 cc::mojom::MojoCompositorFrameSinkRequest request, | |
| 24 cc::mojom::MojoCompositorFrameSinkClientPtr client) override; | |
| 25 | |
| 26 private: | |
| 27 int32_t process_id_; | |
|
Fady Samuel
2017/04/10 02:28:38
nit: const int32_t?
Saman Sami
2017/04/10 02:37:47
Acknowledged.
Saman Sami
2017/04/10 15:05:51
Done.
| |
| 28 mojo::Binding<mojom::FrameSinkProvider> binding_; | |
|
Fady Samuel
2017/04/10 02:28:38
DISALLOW_COPY_AND_ASSIGN...
Saman Sami
2017/04/10 02:37:47
Acknowledged.
Saman Sami
2017/04/10 15:05:51
Done.
| |
| 29 }; | |
| 30 | |
| 31 } // namespace content | |
| 32 | |
| 33 #endif // CONTENT_BROWSER_RENDER_WIDGET_COMPOSITOR_FRAME_SINK_PROVIDER_H_ | |
| OLD | NEW |