Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issue 2774363002: Initialize Ozone in video_decode_accelerator_unittest. (Closed)

Created:
3 years, 8 months ago by kylechar
Modified:
3 years, 8 months ago
Reviewers:
kcwu, Pawel Osciak
CC:
chromium-reviews, posciak+watch_chromium.org, piman+watch_chromium.org, feature-media-reviews_chromium.org, kcwu
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Initialize Ozone in video_decode_accelerator_unittest. Calling gl::init::InitializeGLOneOff() used to initialize Ozone GPU if it wasn't already initialized. This is no longer the case, so add a call to OzonePlatform::InitializeForGPU() before InitializeGLOneOff(). BUG=705466 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2774363002 Cr-Commit-Position: refs/heads/master@{#460007} Committed: https://chromium.googlesource.com/chromium/src/+/b720a94625b27d3c89be30bcbf30f7cb78aa03bd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M media/gpu/rendering_helper.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
kylechar
3 years, 8 months ago (2017-03-27 16:01:17 UTC) #3
kcwu
lgtm Thanks. This fix works for me.
3 years, 8 months ago (2017-03-27 16:09:53 UTC) #5
kylechar
On 2017/03/27 16:09:53, kcwu wrote: > lgtm > > Thanks. This fix works for me. ...
3 years, 8 months ago (2017-03-27 18:19:59 UTC) #10
Pawel Osciak
lgtm
3 years, 8 months ago (2017-03-28 01:05:24 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2774363002/1
3 years, 8 months ago (2017-03-28 03:42:32 UTC) #13
commit-bot: I haz the power
3 years, 8 months ago (2017-03-28 03:49:24 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b720a94625b27d3c89be30bcbf30...

Powered by Google App Engine
This is Rietveld 408576698