Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Issue 2774343004: Call |NavigationItemsPruned| when item is removed in session controller. (Closed)

Created:
3 years, 9 months ago by liaoyuke
Modified:
3 years, 9 months ago
CC:
chromium-reviews, Eugene But (OOO till 7-30), ios-reviews+web_chromium.org, ios-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Call |NavigationItemsPruned| when item is removed in session controller. |removeItemAtIndex| removes an item from CRWSessionController, so |NavigationItemsPruned| should be called to notify observers. BUG= Review-Url: https://codereview.chromium.org/2774343004 Cr-Commit-Position: refs/heads/master@{#460009} Committed: https://chromium.googlesource.com/chromium/src/+/2cc9de46038c9ed3d3959cece913d02759e6b9df

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M ios/web/navigation/crw_session_controller.mm View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
liaoyuke
Hey Eugene, PTAL. Thank you very much!
3 years, 9 months ago (2017-03-27 23:42:38 UTC) #3
Eugene But (OOO till 7-30)
lgtm
3 years, 9 months ago (2017-03-28 01:21:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2774343004/1
3 years, 9 months ago (2017-03-28 04:10:05 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-28 04:14:23 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2cc9de46038c9ed3d3959cece913...

Powered by Google App Engine
This is Rietveld 408576698