Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Issue 2774303002: Set TextInputType of CVC prompt to TEXT_INPUT_TYPE_NUMBER. (Closed)

Created:
3 years, 9 months ago by yhanada
Modified:
3 years, 9 months ago
Reviewers:
Evan Stade
CC:
chromium-reviews, rouslan+autofill_chromium.org, rogerm+autofillwatch_chromium.org, sebsg+autofillwatch_chromium.org, mathp+autofillwatch_chromium.org, tfarina, vabr+watchlistautofill_chromium.org, estade+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Set TextInputType of CVC prompt to TEXT_INPUT_TYPE_NUMBER. BUG=701263 Review-Url: https://codereview.chromium.org/2774303002 Cr-Commit-Position: refs/heads/master@{#459972} Committed: https://chromium.googlesource.com/chromium/src/+/b4bea78349858d797132879b14afe743703fefb2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/browser/ui/views/autofill/card_unmask_prompt_views.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
yhanada1
Hi estade@, PTAL. Thanks!
3 years, 9 months ago (2017-03-27 11:50:33 UTC) #6
yhanada
3 years, 9 months ago (2017-03-27 11:51:10 UTC) #8
Evan Stade
well, I had no idea that existed. I wonder what other textfields might need a ...
3 years, 9 months ago (2017-03-27 17:15:50 UTC) #9
yhanada
On 2017/03/27 17:15:50, Evan Stade wrote: > well, I had no idea that existed. I ...
3 years, 9 months ago (2017-03-28 01:28:39 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2774303002/1
3 years, 9 months ago (2017-03-28 01:29:23 UTC) #12
commit-bot: I haz the power
3 years, 9 months ago (2017-03-28 01:34:55 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b4bea78349858d797132879b14af...

Powered by Google App Engine
This is Rietveld 408576698