Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.h

Issue 2774233007: [Bindings] Move ScriptPromiseProperties from V8HiddenValue to V8PrivateProperty (Closed)
Patch Set: workaround Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.h
diff --git a/third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.h b/third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.h
index 9902dbf2a04552e9fb476bffb8545ffb2ba0dde7..c84f66e10d59010fd2c53f19bc48188e972a386b 100644
--- a/third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.h
+++ b/third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.h
@@ -31,7 +31,6 @@
#include "bindings/core/v8/ScopedPersistent.h"
#include "bindings/core/v8/ScriptState.h"
#include "bindings/core/v8/ScriptWrappableVisitor.h"
-#include "bindings/core/v8/V8HiddenValue.h"
#include "bindings/core/v8/WrapperTypeInfo.h"
#include "core/CoreExport.h"
#include "gin/public/isolate_holder.h"
@@ -132,7 +131,6 @@ class CORE_EXPORT V8PerIsolateData {
bool isUseCounterDisabled() const { return m_useCounterDisabled; }
- V8HiddenValue* hiddenValue() { return m_hiddenValue.get(); }
V8PrivateProperty* privateProperty() { return m_privateProperty.get(); }
// Accessors to the cache of interface templates.
@@ -251,7 +249,6 @@ class CORE_EXPORT V8PerIsolateData {
HashMap<const void*, Vector<v8::Eternal<v8::Name>>> m_eternalNameCache;
std::unique_ptr<StringCache> m_stringCache;
- std::unique_ptr<V8HiddenValue> m_hiddenValue;
std::unique_ptr<V8PrivateProperty> m_privateProperty;
ScopedPersistent<v8::Value> m_liveRoot;
RefPtr<ScriptState> m_scriptRegexpScriptState;

Powered by Google App Engine
This is Rietveld 408576698