Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(568)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.cpp

Issue 2774233007: [Bindings] Move ScriptPromiseProperties from V8HiddenValue to V8PrivateProperty (Closed)
Patch Set: workaround Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.cpp b/third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.cpp
index f4fed2e47739147a93aaf491c761168a297889a1..4e342ceab45f94b49c49c86b3987102eef893416 100644
--- a/third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.cpp
@@ -30,7 +30,6 @@
#include "bindings/core/v8/DOMDataStore.h"
#include "bindings/core/v8/ScriptSourceCode.h"
#include "bindings/core/v8/V8Binding.h"
-#include "bindings/core/v8/V8HiddenValue.h"
#include "bindings/core/v8/V8ObjectConstructor.h"
#include "bindings/core/v8/V8PrivateProperty.h"
#include "bindings/core/v8/V8ScriptRunner.h"
@@ -60,7 +59,6 @@ V8PerIsolateData::V8PerIsolateData(WebTaskRunner* taskRunner)
isMainThread() ? gin::IsolateHolder::kDisallowAtomicsWait
: gin::IsolateHolder::kAllowAtomicsWait),
m_stringCache(WTF::wrapUnique(new StringCache(isolate()))),
- m_hiddenValue(V8HiddenValue::create()),
m_privateProperty(V8PrivateProperty::create()),
m_constructorMode(ConstructorMode::CreateNewObject),
m_useCounterDisabled(false),
@@ -124,7 +122,6 @@ void V8PerIsolateData::destroy(v8::Isolate* isolate) {
if (data->m_scriptRegexpScriptState)
data->m_scriptRegexpScriptState->disposePerContextData();
data->m_liveRoot.clear();
- data->m_hiddenValue.reset();
data->m_privateProperty.reset();
data->m_stringCache->dispose();
data->m_stringCache.reset();

Powered by Google App Engine
This is Rietveld 408576698