Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(936)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8HiddenValue.cpp

Issue 2774233007: [Bindings] Move ScriptPromiseProperties from V8HiddenValue to V8PrivateProperty (Closed)
Patch Set: workaround Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/V8HiddenValue.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/V8HiddenValue.cpp b/third_party/WebKit/Source/bindings/core/v8/V8HiddenValue.cpp
index b04f27386a8bf845f64c78a63825dceafd4ffc9a..c0e2335120b336c3a54ecae16b8767593c101e89 100644
--- a/third_party/WebKit/Source/bindings/core/v8/V8HiddenValue.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/V8HiddenValue.cpp
@@ -10,18 +10,6 @@
namespace blink {
-#define V8_DEFINE_METHOD(name) \
- v8::Local<v8::String> V8HiddenValue::name(v8::Isolate* isolate) { \
- V8HiddenValue* hiddenValue = \
- V8PerIsolateData::from(isolate)->hiddenValue(); \
- if (hiddenValue->m_##name.isEmpty()) { \
- hiddenValue->m_##name.set(isolate, v8AtomicString(isolate, #name)); \
- } \
- return hiddenValue->m_##name.newLocal(isolate); \
- }
-
-V8_HIDDEN_VALUES(V8_DEFINE_METHOD);
-
v8::Local<v8::Value> V8HiddenValue::getHiddenValue(ScriptState* scriptState,
v8::Local<v8::Object> object,
v8::Local<v8::String> key) {
@@ -59,14 +47,4 @@ bool V8HiddenValue::deleteHiddenValue(ScriptState* scriptState,
v8::Undefined(scriptState->isolate())));
}
-v8::Local<v8::Value> V8HiddenValue::getHiddenValueFromMainWorldWrapper(
- ScriptState* scriptState,
- ScriptWrappable* wrappable,
- v8::Local<v8::String> key) {
- v8::Local<v8::Object> wrapper =
- wrappable->mainWorldWrapper(scriptState->isolate());
- return wrapper.IsEmpty() ? v8::Local<v8::Value>()
- : getHiddenValue(scriptState, wrapper, key);
-}
-
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698