Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(648)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8HiddenValue.h

Issue 2774233007: [Bindings] Move ScriptPromiseProperties from V8HiddenValue to V8PrivateProperty (Closed)
Patch Set: workaround Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/V8HiddenValue.h
diff --git a/third_party/WebKit/Source/bindings/core/v8/V8HiddenValue.h b/third_party/WebKit/Source/bindings/core/v8/V8HiddenValue.h
index 85742ab18e58ac949a51f55c5043003a01622e08..32739788c484e65e87666b584323ede3b797503b 100644
--- a/third_party/WebKit/Source/bindings/core/v8/V8HiddenValue.h
+++ b/third_party/WebKit/Source/bindings/core/v8/V8HiddenValue.h
@@ -17,26 +17,9 @@
namespace blink {
class ScriptState;
-class ScriptWrappable;
-
-#define V8_HIDDEN_VALUES(V) \
- SCRIPT_PROMISE_PROPERTIES(V, Promise) \
- SCRIPT_PROMISE_PROPERTIES(V, Resolver)
class CORE_EXPORT V8HiddenValue {
- USING_FAST_MALLOC(V8HiddenValue);
- WTF_MAKE_NONCOPYABLE(V8HiddenValue);
-
public:
- static std::unique_ptr<V8HiddenValue> create() {
- return WTF::wrapUnique(new V8HiddenValue());
- }
-
-#define V8_DECLARE_METHOD(name) \
- static v8::Local<v8::String> name(v8::Isolate* isolate);
- V8_HIDDEN_VALUES(V8_DECLARE_METHOD);
-#undef V8_DECLARE_METHOD
-
static v8::Local<v8::Value> getHiddenValue(ScriptState*,
v8::Local<v8::Object>,
v8::Local<v8::String>);
@@ -47,17 +30,6 @@ class CORE_EXPORT V8HiddenValue {
static bool deleteHiddenValue(ScriptState*,
v8::Local<v8::Object>,
v8::Local<v8::String>);
- static v8::Local<v8::Value> getHiddenValueFromMainWorldWrapper(
- ScriptState*,
- ScriptWrappable*,
- v8::Local<v8::String>);
-
- private:
- V8HiddenValue() {}
-
-#define V8_DECLARE_FIELD(name) ScopedPersistent<v8::String> m_##name;
- V8_HIDDEN_VALUES(V8_DECLARE_FIELD);
-#undef V8_DECLARE_FIELD
};
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698