Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1146)

Unified Diff: build/config/compiler/BUILD.gn

Issue 2774223005: Enable -Wshift-negative-value. (Closed)
Patch Set: sandbox Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/config/compiler/BUILD.gn
diff --git a/build/config/compiler/BUILD.gn b/build/config/compiler/BUILD.gn
index 83d649b4c44ad5724d446fae9df91943c2e4422c..7cc1ae43f69c5ad43717ab7360a496cf020cedad 100644
--- a/build/config/compiler/BUILD.gn
+++ b/build/config/compiler/BUILD.gn
@@ -1078,17 +1078,6 @@ config("default_warnings") {
"-Wno-inconsistent-missing-override",
]
- # Chrome's hermetic Clang compiler, NaCl's Clang compiler and Xcode's Clang
- # compiler will almost always have different versions. Certain flags may not
- # be recognized by one version or the other.
- if (!is_nacl) {
- # Flags NaCl (Clang 3.7) does not recognize.
- cflags += [
- # TODO(thakis): Enable this, crbug.com/507717
- "-Wno-shift-negative-value",
- ]
- }
-
# use_xcode_clang only refers to the iOS toolchain, host binaries use
# chromium's clang always.
if (!is_nacl && (!use_xcode_clang || current_toolchain == host_toolchain)) {
« no previous file with comments | « base/allocator/BUILD.gn ('k') | sandbox/linux/BUILD.gn » ('j') | sandbox/linux/BUILD.gn » ('J')

Powered by Google App Engine
This is Rietveld 408576698