Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Side by Side Diff: build/config/compiler/BUILD.gn

Issue 2774223005: Enable -Wshift-negative-value. (Closed)
Patch Set: sandbox Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/android/config.gni") 5 import("//build/config/android/config.gni")
6 import("//build/config/chrome_build.gni") 6 import("//build/config/chrome_build.gni")
7 import("//build/config/chromecast_build.gni") 7 import("//build/config/chromecast_build.gni")
8 import("//build/config/compiler/compiler.gni") 8 import("//build/config/compiler/compiler.gni")
9 import("//build/config/nacl/config.gni") 9 import("//build/config/nacl/config.gni")
10 import("//build/toolchain/cc_wrapper.gni") 10 import("//build/toolchain/cc_wrapper.gni")
(...skipping 1060 matching lines...) Expand 10 before | Expand all | Expand 10 after
1071 1071
1072 # TODO(thakis): This used to be implied by -Wno-unused-function, 1072 # TODO(thakis): This used to be implied by -Wno-unused-function,
1073 # which we no longer use. Check if it makes sense to remove 1073 # which we no longer use. Check if it makes sense to remove
1074 # this as well. http://crbug.com/316352 1074 # this as well. http://crbug.com/316352
1075 "-Wno-unneeded-internal-declaration", 1075 "-Wno-unneeded-internal-declaration",
1076 1076
1077 # TODO(hans): Get this cleaned up, http://crbug.com/428099 1077 # TODO(hans): Get this cleaned up, http://crbug.com/428099
1078 "-Wno-inconsistent-missing-override", 1078 "-Wno-inconsistent-missing-override",
1079 ] 1079 ]
1080 1080
1081 # Chrome's hermetic Clang compiler, NaCl's Clang compiler and Xcode's Clang
1082 # compiler will almost always have different versions. Certain flags may not
1083 # be recognized by one version or the other.
1084 if (!is_nacl) {
1085 # Flags NaCl (Clang 3.7) does not recognize.
1086 cflags += [
1087 # TODO(thakis): Enable this, crbug.com/507717
1088 "-Wno-shift-negative-value",
1089 ]
1090 }
1091
1092 # use_xcode_clang only refers to the iOS toolchain, host binaries use 1081 # use_xcode_clang only refers to the iOS toolchain, host binaries use
1093 # chromium's clang always. 1082 # chromium's clang always.
1094 if (!is_nacl && (!use_xcode_clang || current_toolchain == host_toolchain)) { 1083 if (!is_nacl && (!use_xcode_clang || current_toolchain == host_toolchain)) {
1095 # Flags NaCl (Clang 3.7) and Xcode 7.3 (Clang clang-703.0.31) do not 1084 # Flags NaCl (Clang 3.7) and Xcode 7.3 (Clang clang-703.0.31) do not
1096 # recognize. 1085 # recognize.
1097 cflags += [ 1086 cflags += [
1098 # TODO(thakis): https://crbug.com/604888 1087 # TODO(thakis): https://crbug.com/604888
1099 "-Wno-undefined-var-template", 1088 "-Wno-undefined-var-template",
1100 1089
1101 # TODO(thakis): https://crbug.com/617318 1090 # TODO(thakis): https://crbug.com/617318
(...skipping 613 matching lines...) Expand 10 before | Expand all | Expand 10 after
1715 1704
1716 if (is_ios || is_mac) { 1705 if (is_ios || is_mac) {
1717 # On Mac and iOS, this enables support for ARC (automatic ref-counting). 1706 # On Mac and iOS, this enables support for ARC (automatic ref-counting).
1718 # See http://clang.llvm.org/docs/AutomaticReferenceCounting.html. 1707 # See http://clang.llvm.org/docs/AutomaticReferenceCounting.html.
1719 config("enable_arc") { 1708 config("enable_arc") {
1720 common_flags = [ "-fobjc-arc" ] 1709 common_flags = [ "-fobjc-arc" ]
1721 cflags_objc = common_flags 1710 cflags_objc = common_flags
1722 cflags_objcc = common_flags 1711 cflags_objcc = common_flags
1723 } 1712 }
1724 } 1713 }
OLDNEW
« no previous file with comments | « base/allocator/BUILD.gn ('k') | sandbox/linux/BUILD.gn » ('j') | sandbox/linux/BUILD.gn » ('J')

Powered by Google App Engine
This is Rietveld 408576698